You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Ryan Sonnek (JIRA)" <ji...@apache.org> on 2007/09/19 04:56:43 UTC
[jira] Created: (WICKET-987) Stripping javascript comments and
whitespace breaks application when using prototype library
Stripping javascript comments and whitespace breaks application when using prototype library
--------------------------------------------------------------------------------------------
Key: WICKET-987
URL: https://issues.apache.org/jira/browse/WICKET-987
Project: Wicket
Issue Type: Bug
Affects Versions: 1.3.0-beta3, 1.3.0-beta2, 1.3.0-beta1
Environment: wicket-1.3.0-beta3, wicketstuff-scriptaculous-1.3-SNAPSHOT
Reporter: Ryan Sonnek
Priority: Blocker
whenever I enable stripping javascript comments and whitespace, I get javascript errors loading my prototype.js file. Since wicket automatically enables this setting when in "DEPLOYMENT" mode, this is a real show stopper for releasing my app.
This has been talked about recently, but I would recommend using an "official" javascript minification library instead of this home rolled implementation. The YUI compressor seems to be correctly licensed and would be a great option, but I don't care as long as this is fixed. see WICKET-918 for more info
attaching sample project that exhibits the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-987) Stripping javascript comments and
whitespace breaks application when using prototype library
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558282#action_12558282 ]
Matej Knopp commented on WICKET-987:
------------------------------------
I'm going to resolve this as fixed again unless someone submits a script that breaks.
> Stripping javascript comments and whitespace breaks application when using prototype library
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-987
> URL: https://issues.apache.org/jira/browse/WICKET-987
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Environment: wicket-1.3.0-beta3, wicketstuff-scriptaculous-1.3-SNAPSHOT
> Reporter: Ryan Sonnek
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.0-beta4
>
> Attachments: minify-javascript.zip
>
>
> whenever I enable stripping javascript comments and whitespace, I get javascript errors loading my prototype.js file. Since wicket automatically enables this setting when in "DEPLOYMENT" mode, this is a real show stopper for releasing my app.
> This has been talked about recently, but I would recommend using an "official" javascript minification library instead of this home rolled implementation. The YUI compressor seems to be correctly licensed and would be a great option, but I don't care as long as this is fixed. see WICKET-918 for more info
> attaching sample project that exhibits the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-987) Stripping javascript comments and
whitespace breaks application when using prototype library
Posted by "Ryan Sonnek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Sonnek reopened WICKET-987:
--------------------------------
reopening since it does not appear to be fixed in 1.3.0.
> Stripping javascript comments and whitespace breaks application when using prototype library
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-987
> URL: https://issues.apache.org/jira/browse/WICKET-987
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Environment: wicket-1.3.0-beta3, wicketstuff-scriptaculous-1.3-SNAPSHOT
> Reporter: Ryan Sonnek
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.0-beta4
>
> Attachments: minify-javascript.zip
>
>
> whenever I enable stripping javascript comments and whitespace, I get javascript errors loading my prototype.js file. Since wicket automatically enables this setting when in "DEPLOYMENT" mode, this is a real show stopper for releasing my app.
> This has been talked about recently, but I would recommend using an "official" javascript minification library instead of this home rolled implementation. The YUI compressor seems to be correctly licensed and would be a great option, but I don't care as long as this is fixed. see WICKET-918 for more info
> attaching sample project that exhibits the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-987) Stripping javascript comments and
whitespace breaks application when using prototype library
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596901#action_12596901 ]
Matej Knopp commented on WICKET-987:
------------------------------------
I just tried that line (document.write("<script id=__onDOMContentLoaded defer src=//:><\/script>");) with current trunk and it strips just fine.
> Stripping javascript comments and whitespace breaks application when using prototype library
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-987
> URL: https://issues.apache.org/jira/browse/WICKET-987
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Environment: wicket-1.3.0-beta3, wicketstuff-scriptaculous-1.3-SNAPSHOT
> Reporter: Ryan Sonnek
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.0-beta4
>
> Attachments: minify-javascript.zip
>
>
> whenever I enable stripping javascript comments and whitespace, I get javascript errors loading my prototype.js file. Since wicket automatically enables this setting when in "DEPLOYMENT" mode, this is a real show stopper for releasing my app.
> This has been talked about recently, but I would recommend using an "official" javascript minification library instead of this home rolled implementation. The YUI compressor seems to be correctly licensed and would be a great option, but I don't care as long as this is fixed. see WICKET-918 for more info
> attaching sample project that exhibits the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-987) Stripping javascript comments and
whitespace breaks application when using prototype library
Posted by "Carlos Pita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596811#action_12596811 ]
Carlos Pita commented on WICKET-987:
------------------------------------
Line 4025 of prototype 1.6.0.2 gets truncated from
document.write("<script id=__onDOMContentLoaded defer src=//:><\/script>");
to
document.write("<script id=__onDOMContentLoaded defer src=
on deployment mode. I think this is critical because it would probably be fatal for applications in production that depends on prototype (ours does).
> Stripping javascript comments and whitespace breaks application when using prototype library
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-987
> URL: https://issues.apache.org/jira/browse/WICKET-987
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Environment: wicket-1.3.0-beta3, wicketstuff-scriptaculous-1.3-SNAPSHOT
> Reporter: Ryan Sonnek
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.0-beta4
>
> Attachments: minify-javascript.zip
>
>
> whenever I enable stripping javascript comments and whitespace, I get javascript errors loading my prototype.js file. Since wicket automatically enables this setting when in "DEPLOYMENT" mode, this is a real show stopper for releasing my app.
> This has been talked about recently, but I would recommend using an "official" javascript minification library instead of this home rolled implementation. The YUI compressor seems to be correctly licensed and would be a great option, but I don't care as long as this is fixed. see WICKET-918 for more info
> attaching sample project that exhibits the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-987) Stripping javascript comments and
whitespace breaks application when using prototype library
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matej Knopp closed WICKET-987.
------------------------------
> Stripping javascript comments and whitespace breaks application when using prototype library
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-987
> URL: https://issues.apache.org/jira/browse/WICKET-987
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Environment: wicket-1.3.0-beta3, wicketstuff-scriptaculous-1.3-SNAPSHOT
> Reporter: Ryan Sonnek
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.0-beta4
>
> Attachments: minify-javascript.zip
>
>
> whenever I enable stripping javascript comments and whitespace, I get javascript errors loading my prototype.js file. Since wicket automatically enables this setting when in "DEPLOYMENT" mode, this is a real show stopper for releasing my app.
> This has been talked about recently, but I would recommend using an "official" javascript minification library instead of this home rolled implementation. The YUI compressor seems to be correctly licensed and would be a great option, but I don't care as long as this is fixed. see WICKET-918 for more info
> attaching sample project that exhibits the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-987) Stripping javascript comments and
whitespace breaks application when using prototype library
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-987:
--------------------------------------
Fix Version/s: (was: 1.3.0-beta5)
1.3.0-beta4
> Stripping javascript comments and whitespace breaks application when using prototype library
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-987
> URL: https://issues.apache.org/jira/browse/WICKET-987
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Environment: wicket-1.3.0-beta3, wicketstuff-scriptaculous-1.3-SNAPSHOT
> Reporter: Ryan Sonnek
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.0-beta4
>
> Attachments: minify-javascript.zip
>
>
> whenever I enable stripping javascript comments and whitespace, I get javascript errors loading my prototype.js file. Since wicket automatically enables this setting when in "DEPLOYMENT" mode, this is a real show stopper for releasing my app.
> This has been talked about recently, but I would recommend using an "official" javascript minification library instead of this home rolled implementation. The YUI compressor seems to be correctly licensed and would be a great option, but I don't care as long as this is fixed. see WICKET-918 for more info
> attaching sample project that exhibits the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-987) Stripping javascript comments and
whitespace breaks application when using prototype library
Posted by "Ryan Sonnek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Sonnek updated WICKET-987:
-------------------------------
Attachment: minify-javascript.zip
sample project that has the issue. to startup application on port 8080 run:
mvn jetty:run
> Stripping javascript comments and whitespace breaks application when using prototype library
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-987
> URL: https://issues.apache.org/jira/browse/WICKET-987
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Environment: wicket-1.3.0-beta3, wicketstuff-scriptaculous-1.3-SNAPSHOT
> Reporter: Ryan Sonnek
> Priority: Blocker
> Attachments: minify-javascript.zip
>
>
> whenever I enable stripping javascript comments and whitespace, I get javascript errors loading my prototype.js file. Since wicket automatically enables this setting when in "DEPLOYMENT" mode, this is a real show stopper for releasing my app.
> This has been talked about recently, but I would recommend using an "official" javascript minification library instead of this home rolled implementation. The YUI compressor seems to be correctly licensed and would be a great option, but I don't care as long as this is fixed. see WICKET-918 for more info
> attaching sample project that exhibits the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-987) Stripping javascript comments and
whitespace breaks application when using prototype library
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-987:
--------------------------------------
Fix Version/s: (was: 1.3.0-beta4)
1.3.0-beta5
> Stripping javascript comments and whitespace breaks application when using prototype library
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-987
> URL: https://issues.apache.org/jira/browse/WICKET-987
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Environment: wicket-1.3.0-beta3, wicketstuff-scriptaculous-1.3-SNAPSHOT
> Reporter: Ryan Sonnek
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.0-beta5
>
> Attachments: minify-javascript.zip
>
>
> whenever I enable stripping javascript comments and whitespace, I get javascript errors loading my prototype.js file. Since wicket automatically enables this setting when in "DEPLOYMENT" mode, this is a real show stopper for releasing my app.
> This has been talked about recently, but I would recommend using an "official" javascript minification library instead of this home rolled implementation. The YUI compressor seems to be correctly licensed and would be a great option, but I don't care as long as this is fixed. see WICKET-918 for more info
> attaching sample project that exhibits the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-987) Stripping javascript
comments and whitespace breaks application when using prototype library
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596905#action_12596905 ]
knopp edited comment on WICKET-987 at 5/14/08 12:05 PM:
--------------------------------------------------------------
Okay, with whole file i can see it. But the problem is before that line. This regex breaks the stripper
/\[((?:[\w-]*:)?[\w-]+)\s*(?:([!^$*~|]?=)\s*((['"])([^\4]*?)\4|([^'"][^\]]*?)))?\]/
was (Author: knopp):
Okay, with whole file i can see it. But the problem is before that line.
> Stripping javascript comments and whitespace breaks application when using prototype library
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-987
> URL: https://issues.apache.org/jira/browse/WICKET-987
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Environment: wicket-1.3.0-beta3, wicketstuff-scriptaculous-1.3-SNAPSHOT
> Reporter: Ryan Sonnek
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.0-beta4
>
> Attachments: minify-javascript.zip
>
>
> whenever I enable stripping javascript comments and whitespace, I get javascript errors loading my prototype.js file. Since wicket automatically enables this setting when in "DEPLOYMENT" mode, this is a real show stopper for releasing my app.
> This has been talked about recently, but I would recommend using an "official" javascript minification library instead of this home rolled implementation. The YUI compressor seems to be correctly licensed and would be a great option, but I don't care as long as this is fixed. see WICKET-918 for more info
> attaching sample project that exhibits the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-987) Stripping javascript comments and
whitespace breaks application when using prototype library
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596905#action_12596905 ]
Matej Knopp commented on WICKET-987:
------------------------------------
Okay, with whole file i can see it. But the problem is before that line.
> Stripping javascript comments and whitespace breaks application when using prototype library
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-987
> URL: https://issues.apache.org/jira/browse/WICKET-987
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Environment: wicket-1.3.0-beta3, wicketstuff-scriptaculous-1.3-SNAPSHOT
> Reporter: Ryan Sonnek
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.0-beta4
>
> Attachments: minify-javascript.zip
>
>
> whenever I enable stripping javascript comments and whitespace, I get javascript errors loading my prototype.js file. Since wicket automatically enables this setting when in "DEPLOYMENT" mode, this is a real show stopper for releasing my app.
> This has been talked about recently, but I would recommend using an "official" javascript minification library instead of this home rolled implementation. The YUI compressor seems to be correctly licensed and would be a great option, but I don't care as long as this is fixed. see WICKET-918 for more info
> attaching sample project that exhibits the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-987) Stripping javascript comments and
whitespace breaks application when using prototype library
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596917#action_12596917 ]
Matej Knopp commented on WICKET-987:
------------------------------------
Actually, it's the part right before the regexp. Anyway, should be fixed in trunk, thanks for report. Can anyone bother to commit this to 1.3?
> Stripping javascript comments and whitespace breaks application when using prototype library
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-987
> URL: https://issues.apache.org/jira/browse/WICKET-987
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Environment: wicket-1.3.0-beta3, wicketstuff-scriptaculous-1.3-SNAPSHOT
> Reporter: Ryan Sonnek
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.0-beta4
>
> Attachments: minify-javascript.zip
>
>
> whenever I enable stripping javascript comments and whitespace, I get javascript errors loading my prototype.js file. Since wicket automatically enables this setting when in "DEPLOYMENT" mode, this is a real show stopper for releasing my app.
> This has been talked about recently, but I would recommend using an "official" javascript minification library instead of this home rolled implementation. The YUI compressor seems to be correctly licensed and would be a great option, but I don't care as long as this is fixed. see WICKET-918 for more info
> attaching sample project that exhibits the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-987) Stripping javascript comments and
whitespace breaks application when using prototype library
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matej Knopp resolved WICKET-987.
--------------------------------
Resolution: Fixed
> Stripping javascript comments and whitespace breaks application when using prototype library
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-987
> URL: https://issues.apache.org/jira/browse/WICKET-987
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Environment: wicket-1.3.0-beta3, wicketstuff-scriptaculous-1.3-SNAPSHOT
> Reporter: Ryan Sonnek
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.0-beta4
>
> Attachments: minify-javascript.zip
>
>
> whenever I enable stripping javascript comments and whitespace, I get javascript errors loading my prototype.js file. Since wicket automatically enables this setting when in "DEPLOYMENT" mode, this is a real show stopper for releasing my app.
> This has been talked about recently, but I would recommend using an "official" javascript minification library instead of this home rolled implementation. The YUI compressor seems to be correctly licensed and would be a great option, but I don't care as long as this is fixed. see WICKET-918 for more info
> attaching sample project that exhibits the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-987) Stripping javascript comments and
whitespace breaks application when using prototype library
Posted by "Edward Yakop (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557678#action_12557678 ]
Edward Yakop commented on WICKET-987:
-------------------------------------
This bug is re-appear in the wicket 1.3.0 in the release version.
> Stripping javascript comments and whitespace breaks application when using prototype library
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-987
> URL: https://issues.apache.org/jira/browse/WICKET-987
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Environment: wicket-1.3.0-beta3, wicketstuff-scriptaculous-1.3-SNAPSHOT
> Reporter: Ryan Sonnek
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.0-beta4
>
> Attachments: minify-javascript.zip
>
>
> whenever I enable stripping javascript comments and whitespace, I get javascript errors loading my prototype.js file. Since wicket automatically enables this setting when in "DEPLOYMENT" mode, this is a real show stopper for releasing my app.
> This has been talked about recently, but I would recommend using an "official" javascript minification library instead of this home rolled implementation. The YUI compressor seems to be correctly licensed and would be a great option, but I don't care as long as this is fixed. see WICKET-918 for more info
> attaching sample project that exhibits the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-987) Stripping javascript comments and
whitespace breaks application when using prototype library
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557732#action_12557732 ]
Matej Knopp commented on WICKET-987:
------------------------------------
Just a snippet of javascript that fails when minified would be enough.
> Stripping javascript comments and whitespace breaks application when using prototype library
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-987
> URL: https://issues.apache.org/jira/browse/WICKET-987
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Environment: wicket-1.3.0-beta3, wicketstuff-scriptaculous-1.3-SNAPSHOT
> Reporter: Ryan Sonnek
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.0-beta4
>
> Attachments: minify-javascript.zip
>
>
> whenever I enable stripping javascript comments and whitespace, I get javascript errors loading my prototype.js file. Since wicket automatically enables this setting when in "DEPLOYMENT" mode, this is a real show stopper for releasing my app.
> This has been talked about recently, but I would recommend using an "official" javascript minification library instead of this home rolled implementation. The YUI compressor seems to be correctly licensed and would be a great option, but I don't care as long as this is fixed. see WICKET-918 for more info
> attaching sample project that exhibits the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-987) Stripping javascript comments and
whitespace breaks application when using prototype library
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528712 ]
Matej Knopp commented on WICKET-987:
------------------------------------
Thanks for the quickstart. The problem with Javascript stripper should be fixed in trunk. The javascripts now load well. Still, the plugable stripper is on my to-do list and I'll try implement it soon.
> Stripping javascript comments and whitespace breaks application when using prototype library
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-987
> URL: https://issues.apache.org/jira/browse/WICKET-987
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Environment: wicket-1.3.0-beta3, wicketstuff-scriptaculous-1.3-SNAPSHOT
> Reporter: Ryan Sonnek
> Assignee: Matej Knopp
> Priority: Blocker
> Attachments: minify-javascript.zip
>
>
> whenever I enable stripping javascript comments and whitespace, I get javascript errors loading my prototype.js file. Since wicket automatically enables this setting when in "DEPLOYMENT" mode, this is a real show stopper for releasing my app.
> This has been talked about recently, but I would recommend using an "official" javascript minification library instead of this home rolled implementation. The YUI compressor seems to be correctly licensed and would be a great option, but I don't care as long as this is fixed. see WICKET-918 for more info
> attaching sample project that exhibits the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-987) Stripping javascript comments and
whitespace breaks application when using prototype library
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557730#action_12557730 ]
Matej Knopp commented on WICKET-987:
------------------------------------
Really? Can I get a quickstart then? Works okay for me, even with scriptaculous (tested with current trunk, I don't suppose it's different than wicket-1.3 final).
> Stripping javascript comments and whitespace breaks application when using prototype library
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-987
> URL: https://issues.apache.org/jira/browse/WICKET-987
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Environment: wicket-1.3.0-beta3, wicketstuff-scriptaculous-1.3-SNAPSHOT
> Reporter: Ryan Sonnek
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.0-beta4
>
> Attachments: minify-javascript.zip
>
>
> whenever I enable stripping javascript comments and whitespace, I get javascript errors loading my prototype.js file. Since wicket automatically enables this setting when in "DEPLOYMENT" mode, this is a real show stopper for releasing my app.
> This has been talked about recently, but I would recommend using an "official" javascript minification library instead of this home rolled implementation. The YUI compressor seems to be correctly licensed and would be a great option, but I don't care as long as this is fixed. see WICKET-918 for more info
> attaching sample project that exhibits the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-987) Stripping javascript comments and
whitespace breaks application when using prototype library
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matej Knopp resolved WICKET-987.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.3.0-beta4
> Stripping javascript comments and whitespace breaks application when using prototype library
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-987
> URL: https://issues.apache.org/jira/browse/WICKET-987
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Environment: wicket-1.3.0-beta3, wicketstuff-scriptaculous-1.3-SNAPSHOT
> Reporter: Ryan Sonnek
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.0-beta4
>
> Attachments: minify-javascript.zip
>
>
> whenever I enable stripping javascript comments and whitespace, I get javascript errors loading my prototype.js file. Since wicket automatically enables this setting when in "DEPLOYMENT" mode, this is a real show stopper for releasing my app.
> This has been talked about recently, but I would recommend using an "official" javascript minification library instead of this home rolled implementation. The YUI compressor seems to be correctly licensed and would be a great option, but I don't care as long as this is fixed. see WICKET-918 for more info
> attaching sample project that exhibits the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-987) Stripping javascript comments and
whitespace breaks application when using prototype library
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matej Knopp reassigned WICKET-987:
----------------------------------
Assignee: Matej Knopp
> Stripping javascript comments and whitespace breaks application when using prototype library
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-987
> URL: https://issues.apache.org/jira/browse/WICKET-987
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
> Environment: wicket-1.3.0-beta3, wicketstuff-scriptaculous-1.3-SNAPSHOT
> Reporter: Ryan Sonnek
> Assignee: Matej Knopp
> Priority: Blocker
> Attachments: minify-javascript.zip
>
>
> whenever I enable stripping javascript comments and whitespace, I get javascript errors loading my prototype.js file. Since wicket automatically enables this setting when in "DEPLOYMENT" mode, this is a real show stopper for releasing my app.
> This has been talked about recently, but I would recommend using an "official" javascript minification library instead of this home rolled implementation. The YUI compressor seems to be correctly licensed and would be a great option, but I don't care as long as this is fixed. see WICKET-918 for more info
> attaching sample project that exhibits the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.