[GitHub] [geode-native] echobravopapa commented on a change in pull request #743: GEODE-8929: fix 'leaked disk space' issue in logger

[GitBox <gi...@apache.org>]

echobravopapa commented on a change in pull request #743:
URL: https://github.com/apache/geode-native/pull/743#discussion_r573276133



##########
File path: cppcache/src/Log.cpp
##########
@@ -105,8 +105,8 @@ void Log::validateSizeLimits(int64_t fileSizeLimit, int64_t diskSpaceLimit) {
 void Log::init(LogLevel level, const char* logFileName, int32_t logFileLimit,
                int64_t logDiskSpaceLimit) {
   auto logFileNameString =
-      logFileName ? std::string(logFileName) : std::string();
-  init(level, std::string(logFileNameString), logFileLimit, logDiskSpaceLimit);
+      logFileName ? std::string(logFileName) : std::string("geode-native.log");

Review comment:
       is there a test checking the repeated use of the default log file name?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org