You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/18 09:31:18 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1420: libc: Don't define localtime[_r] to macro when CONFIG_LIBC_LOCALTIME not define

xiaoxiang781216 opened a new pull request #1420:
URL: https://github.com/apache/incubator-nuttx/pull/1420


   ## Summary
   since libc++ declare these function in ctime by:
   ```
   using ::localtime[_r];
   ```
   
   ## Impact
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1420: libc: Don't define localtime[_r] to macro when CONFIG_LIBC_LOCALTIME not define

Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #1420:
URL: https://github.com/apache/incubator-nuttx/pull/1420#discussion_r456953053



##########
File path: arch/renesas/src/rx65n/rx65n_rtc.c
##########
@@ -774,7 +774,6 @@ int up_rtc_settime(FAR const struct timespec *tp)
 
   /* Day of the week (0-6, 0=Sunday) */
 
-#if defined(CONFIG_LIBC_LOCALTIME) || defined(CONFIG_TIME_EXTENDED)

Review comment:
       Should this be just conditional on CONFIG_TIME_EXTENDED now?

##########
File path: arch/renesas/src/rx65n/rx65n_rtc.c
##########
@@ -1355,9 +1353,7 @@ int up_rtc_getdatetime(FAR struct tm *tp)
 
       /* Days since Sunday (0-6) */
 
-#if defined(CONFIG_LIBC_LOCALTIME) || defined(CONFIG_TIME_EXTENDED)

Review comment:
       Same question




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1420: libc: Don't define localtime[_r] to macro when CONFIG_LIBC_LOCALTIME not define

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1420:
URL: https://github.com/apache/incubator-nuttx/pull/1420#discussion_r456993757



##########
File path: arch/renesas/src/rx65n/rx65n_rtc.c
##########
@@ -774,7 +774,6 @@ int up_rtc_settime(FAR const struct timespec *tp)
 
   /* Day of the week (0-6, 0=Sunday) */
 
-#if defined(CONFIG_LIBC_LOCALTIME) || defined(CONFIG_TIME_EXTENDED)

Review comment:
       The CONFIG_TIME_EXTENDED is redundant after this commit:
   ```
   commit 1e3f457c9ef71cbaa751d8ad8348ad1993b956b0
   Author: Xiang Xiao <xi...@xiaomi.com>
   Date:   Thu Jan 23 08:17:22 2020 -0600
   
       Remove TIME_EXTENDED option to more conform C standard
       
       Gregory Nutt <gn...@nuttx.org>
       
           Run all .c and .h files modified in this PR through nxstyle and correct all coding standard problems.
       
       Xiang Xiao <xi...@xiaomi.com>
       
           Remove TIME_EXTENDED option to more conform C standard
       
           Note: the code/data size increment is small
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1420: libc: Don't define localtime[_r] to macro when CONFIG_LIBC_LOCALTIME not define

Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #1420:
URL: https://github.com/apache/incubator-nuttx/pull/1420#discussion_r456997813



##########
File path: arch/renesas/src/rx65n/rx65n_rtc.c
##########
@@ -774,7 +774,6 @@ int up_rtc_settime(FAR const struct timespec *tp)
 
   /* Day of the week (0-6, 0=Sunday) */
 
-#if defined(CONFIG_LIBC_LOCALTIME) || defined(CONFIG_TIME_EXTENDED)

Review comment:
       Thanks for clarifying.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton merged pull request #1420: libc: Don't define localtime[_r] to macro when CONFIG_LIBC_LOCALTIME not define

Posted by GitBox <gi...@apache.org>.
btashton merged pull request #1420:
URL: https://github.com/apache/incubator-nuttx/pull/1420


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org