You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (Created) (JIRA)" <ji...@apache.org> on 2011/10/07 12:22:30 UTC
[jira] [Created] (BOOKKEEPER-72) Fix warnings issued by FindBugs
Fix warnings issued by FindBugs
-------------------------------
Key: BOOKKEEPER-72
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-72
Project: Bookkeeper
Issue Type: Bug
Reporter: Ivan Kelly
Fix warnings issued by FindBugs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-72) Fix warnings issued by FindBugs
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-72:
---------------------------------
Attachment: BOOKKEEPER-72.diff
This patch fixes the findbugs in hedwig-*.
> Fix warnings issued by FindBugs
> -------------------------------
>
> Key: BOOKKEEPER-72
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-72
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-72.diff, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml
>
>
> Fix warnings issued by FindBugs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-72) Fix warnings issued by FindBugs
Posted by "Ivan Kelly (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-72:
---------------------------------
Priority: Blocker (was: Major)
Fix Version/s: (was: 4.0.0)
4.1.0
There's too many warning to fix before this release. Making a blocker for 4.1.0.
> Fix warnings issued by FindBugs
> -------------------------------
>
> Key: BOOKKEEPER-72
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-72
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.1.0
>
> Attachments: findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml
>
>
> Fix warnings issued by FindBugs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (BOOKKEEPER-72) Fix warnings issued by FindBugs
Posted by "Ivan Kelly (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly reassigned BOOKKEEPER-72:
------------------------------------
Assignee: Ivan Kelly
> Fix warnings issued by FindBugs
> -------------------------------
>
> Key: BOOKKEEPER-72
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-72
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.0.0
>
>
> Fix warnings issued by FindBugs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-72) Fix warnings issued by FindBugs
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277972#comment-13277972 ]
Hudson commented on BOOKKEEPER-72:
----------------------------------
Integrated in bookkeeper-trunk #515 (See [https://builds.apache.org/job/bookkeeper-trunk/515/])
BOOKKEEPER-72: Fix warnings issued by FindBugs (ivank) (Revision 1339691)
Result = SUCCESS
ivank :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkPublisher.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkSubscriber.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkUtils.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/handlers/SubscribeResponseHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/util/HedwigSocketAddress.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/util/PathUtils.java
* /zookeeper/bookkeeper/trunk/hedwig-protocol/src/main/java/org/apache/hedwig/protoextensions/PubSubResponseUtils.java
* /zookeeper/bookkeeper/trunk/hedwig-server/pom.xml
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/HedwigAdmin.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigCommands.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigConsole.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/ReadTopic.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/common/TerminateJVMExceptionHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/delivery/ChannelEndPoint.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/delivery/DeliveryManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerBean.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/persistence/LocalDBPersistenceManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/proxy/HedwigProxy.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxyConfiguration.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/regions/RegionManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AbstractSubscriptionManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/TrueFilter.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkTopicManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/zookeeper/SafeAsyncCallback.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/resources/findbugsExclude.xml
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/HedwigHubTestBase.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/HedwigRegionTestBase.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/PubSubServerStandAloneTestBase.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/TestPubSubServerStartup.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/delivery/StubDeliveryManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/integration/TestHedwigHub.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/netty/TestPubSubServer.java
> Fix warnings issued by FindBugs
> -------------------------------
>
> Key: BOOKKEEPER-72
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-72
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-72.diff, BOOKKEEPER-72.diff, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml
>
>
> Fix warnings issued by FindBugs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-72) Fix warnings issued by FindBugs
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261770#comment-13261770 ]
Uma Maheswara Rao G commented on BOOKKEEPER-72:
-----------------------------------------------
Thanks Ivan, for the deatils. I just filed a bug BOOKKEEPER-228 for BK Bench. You can assign that issue to me. I will take care of it.
> Fix warnings issued by FindBugs
> -------------------------------
>
> Key: BOOKKEEPER-72
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-72
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.1.0
>
> Attachments: findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml
>
>
> Fix warnings issued by FindBugs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-72) Fix warnings issued by FindBugs
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-72:
---------------------------------
Attachment: BOOKKEEPER-72.diff
New patch. rebased to trunk and added findbugs exclude for findbugs for localdb persistence manager. This findbug cannot be fixed as there's no way to use an SQL parameter for a table in a query. I hash the topic to about SQL injections.
> Fix warnings issued by FindBugs
> -------------------------------
>
> Key: BOOKKEEPER-72
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-72
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-72.diff, BOOKKEEPER-72.diff, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml
>
>
> Fix warnings issued by FindBugs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-72) Fix warnings issued by FindBugs
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277746#comment-13277746 ]
Sijie Guo commented on BOOKKEEPER-72:
-------------------------------------
the patch looks good to me. +1
> Fix warnings issued by FindBugs
> -------------------------------
>
> Key: BOOKKEEPER-72
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-72
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-72.diff, BOOKKEEPER-72.diff, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml
>
>
> Fix warnings issued by FindBugs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-72) Fix warnings issued by FindBugs
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261741#comment-13261741 ]
Ivan Kelly commented on BOOKKEEPER-72:
--------------------------------------
Actually, I have most of it done. I have about 36 more to do in hedwig-server. hedwig-protocol & hedwig-client are done (both were tiny). There's already a patch available to bookkeeper-server. bookkeeper-benchmark is still untouched if you want to look at that.
> Fix warnings issued by FindBugs
> -------------------------------
>
> Key: BOOKKEEPER-72
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-72
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.1.0
>
> Attachments: findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml
>
>
> Fix warnings issued by FindBugs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-72) Fix warnings issued by FindBugs
Posted by "Ivan Kelly (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-72:
---------------------------------
Fix Version/s: 4.0.0
> Fix warnings issued by FindBugs
> -------------------------------
>
> Key: BOOKKEEPER-72
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-72
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Fix For: 4.0.0
>
>
> Fix warnings issued by FindBugs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-72) Fix warnings issued by FindBugs
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261788#comment-13261788 ]
Flavio Junqueira commented on BOOKKEEPER-72:
--------------------------------------------
I have added Uma to the contributors list.
> Fix warnings issued by FindBugs
> -------------------------------
>
> Key: BOOKKEEPER-72
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-72
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.1.0
>
> Attachments: findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml
>
>
> Fix warnings issued by FindBugs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-72) Fix warnings issued by FindBugs
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261734#comment-13261734 ]
Uma Maheswara Rao G commented on BOOKKEEPER-72:
-----------------------------------------------
Hi Ivan,
Lets split the work based on bug category. As bug count is 54 currently. Some might have addressed already.
Also my suggestion is to add exclude filter file to add any invalid bugs into it.
> Fix warnings issued by FindBugs
> -------------------------------
>
> Key: BOOKKEEPER-72
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-72
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.1.0
>
> Attachments: findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml
>
>
> Fix warnings issued by FindBugs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-72) Fix warnings issued by FindBugs
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261825#comment-13261825 ]
Uma Maheswara Rao G commented on BOOKKEEPER-72:
-----------------------------------------------
Thanks a lot Flavio and Ivan.
> Fix warnings issued by FindBugs
> -------------------------------
>
> Key: BOOKKEEPER-72
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-72
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.1.0
>
> Attachments: findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml
>
>
> Fix warnings issued by FindBugs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-72) Fix warnings issued by FindBugs
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261776#comment-13261776 ]
Ivan Kelly commented on BOOKKEEPER-72:
--------------------------------------
I can't find your name on the assignee list :/ I'll ask the infra guys.
> Fix warnings issued by FindBugs
> -------------------------------
>
> Key: BOOKKEEPER-72
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-72
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.1.0
>
> Attachments: findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml
>
>
> Fix warnings issued by FindBugs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-72) Fix warnings issued by FindBugs
Posted by "Ivan Kelly (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-72:
---------------------------------
Attachment: findbugsXml.xml
findbugsXml.xml
findbugsXml.xml
findbugsXml.xml
findbugsXml.xml
Attached warnings.
> Fix warnings issued by FindBugs
> -------------------------------
>
> Key: BOOKKEEPER-72
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-72
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.0.0
>
> Attachments: findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml
>
>
> Fix warnings issued by FindBugs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-72) Fix warnings issued by FindBugs
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269694#comment-13269694 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-72:
---------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5051/
-----------------------------------------------------------
Review request for bookkeeper.
Summary
-------
This patch is for the hedwig components of Bookkeeper.
This addresses bug BOOKKEEPER-72.
https://issues.apache.org/jira/browse/BOOKKEEPER-72
Diffs
-----
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AbstractSubscriptionManager.java ba841af
hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxyConfiguration.java fc811e9
hedwig-server/src/main/java/org/apache/hedwig/server/regions/RegionManager.java b84d9c3
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java 4df1368
hedwig-server/src/main/java/org/apache/hedwig/server/proxy/HedwigProxy.java 118340a
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/LocalDBPersistenceManager.java 4eff593
hedwig-server/src/main/java/org/apache/hedwig/server/delivery/DeliveryManager.java 7ac6d43
hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java 7cc950c
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerBean.java 71c481e
hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java 52089f5
hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java 925e6b7
hedwig-server/src/main/java/org/apache/hedwig/admin/console/ReadTopic.java cfea7f4
hedwig-server/src/main/java/org/apache/hedwig/server/common/TerminateJVMExceptionHandler.java ae8f439
hedwig-server/src/main/java/org/apache/hedwig/server/delivery/ChannelEndPoint.java b5e9922
hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigCommands.java a17f56b
hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigConsole.java 5da8e16
hedwig-client/src/main/java/org/apache/hedwig/util/HedwigSocketAddress.java a6cf89e
hedwig-client/src/main/java/org/apache/hedwig/util/PathUtils.java b989057
hedwig-protocol/src/main/java/org/apache/hedwig/protoextensions/PubSubResponseUtils.java 8660544
hedwig-server/pom.xml 12c8eba
hedwig-server/src/main/java/org/apache/hedwig/admin/HedwigAdmin.java b2ef3a8
hedwig-client/src/main/java/org/apache/hedwig/client/handlers/SubscribeResponseHandler.java c17ffcb
hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkUtils.java 77a09d0
hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkPublisher.java 54c5ce5
hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkSubscriber.java 5ff4bc8
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/TrueFilter.java 3804705
hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkTopicManager.java 5fbcbc4
hedwig-server/src/main/java/org/apache/hedwig/zookeeper/SafeAsyncCallback.java d1f755e
hedwig-server/src/test/java/org/apache/hedwig/server/HedwigHubTestBase.java 6d91167
hedwig-server/src/test/java/org/apache/hedwig/server/HedwigRegionTestBase.java 2252f43
hedwig-server/src/test/java/org/apache/hedwig/server/PubSubServerStandAloneTestBase.java 5f6e363
hedwig-server/src/test/java/org/apache/hedwig/server/TestPubSubServerStartup.java 65e2bd2
hedwig-server/src/test/java/org/apache/hedwig/server/delivery/StubDeliveryManager.java fdc308d
hedwig-server/src/test/java/org/apache/hedwig/server/integration/TestHedwigHub.java eef014c
hedwig-server/src/test/java/org/apache/hedwig/server/netty/TestPubSubServer.java a11921e
Diff: https://reviews.apache.org/r/5051/diff
Testing
-------
Thanks,
Ivan
> Fix warnings issued by FindBugs
> -------------------------------
>
> Key: BOOKKEEPER-72
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-72
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-72.diff, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml
>
>
> Fix warnings issued by FindBugs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-72) Fix warnings issued by FindBugs
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272299#comment-13272299 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-72:
---------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5051/
-----------------------------------------------------------
(Updated 2012-05-10 12:59:25.008772)
Review request for bookkeeper.
Changes
-------
Added findbugsExclude.xml
Summary
-------
This patch is for the hedwig components of Bookkeeper.
This addresses bug BOOKKEEPER-72.
https://issues.apache.org/jira/browse/BOOKKEEPER-72
Diffs (updated)
-----
hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkPublisher.java 54c5ce5
hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkSubscriber.java 5ff4bc8
hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkUtils.java 77a09d0
hedwig-client/src/main/java/org/apache/hedwig/client/handlers/SubscribeResponseHandler.java c17ffcb
hedwig-client/src/main/java/org/apache/hedwig/util/HedwigSocketAddress.java a6cf89e
hedwig-client/src/main/java/org/apache/hedwig/util/PathUtils.java b989057
hedwig-protocol/src/main/java/org/apache/hedwig/protoextensions/PubSubResponseUtils.java 8660544
hedwig-server/pom.xml c7e41c9
hedwig-server/src/main/java/org/apache/hedwig/admin/HedwigAdmin.java b2ef3a8
hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigCommands.java a17f56b
hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigConsole.java 5da8e16
hedwig-server/src/main/java/org/apache/hedwig/admin/console/ReadTopic.java cfea7f4
hedwig-server/src/main/java/org/apache/hedwig/server/common/TerminateJVMExceptionHandler.java ae8f439
hedwig-server/src/main/java/org/apache/hedwig/server/delivery/ChannelEndPoint.java b5e9922
hedwig-server/src/main/java/org/apache/hedwig/server/delivery/DeliveryManager.java 7ac6d43
hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java 7cc950c
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerBean.java 71c481e
hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java 52089f5
hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java 925e6b7
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/LocalDBPersistenceManager.java 4eff593
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java 4df1368
hedwig-server/src/main/java/org/apache/hedwig/server/proxy/HedwigProxy.java 118340a
hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxyConfiguration.java fc811e9
hedwig-server/src/main/java/org/apache/hedwig/server/regions/RegionManager.java b84d9c3
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AbstractSubscriptionManager.java ba841af
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/TrueFilter.java 3804705
hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkTopicManager.java 5fbcbc4
hedwig-server/src/main/java/org/apache/hedwig/zookeeper/SafeAsyncCallback.java d1f755e
hedwig-server/src/main/resources/findbugsExclude.xml PRE-CREATION
hedwig-server/src/test/java/org/apache/hedwig/server/HedwigHubTestBase.java 6b2e731
hedwig-server/src/test/java/org/apache/hedwig/server/HedwigRegionTestBase.java 2252f43
hedwig-server/src/test/java/org/apache/hedwig/server/PubSubServerStandAloneTestBase.java 5f6e363
hedwig-server/src/test/java/org/apache/hedwig/server/TestPubSubServerStartup.java 65e2bd2
hedwig-server/src/test/java/org/apache/hedwig/server/delivery/StubDeliveryManager.java fdc308d
hedwig-server/src/test/java/org/apache/hedwig/server/integration/TestHedwigHub.java eef014c
hedwig-server/src/test/java/org/apache/hedwig/server/netty/TestPubSubServer.java a11921e
Diff: https://reviews.apache.org/r/5051/diff
Testing
-------
Thanks,
Ivan
> Fix warnings issued by FindBugs
> -------------------------------
>
> Key: BOOKKEEPER-72
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-72
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-72.diff, BOOKKEEPER-72.diff, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml
>
>
> Fix warnings issued by FindBugs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira