You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bi...@apache.org on 2003/03/12 08:41:04 UTC

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteAdapter.java

billbarker    2003/03/11 23:41:04

  Modified:    coyote/src/java/org/apache/coyote/tomcat4 CoyoteAdapter.java
  Log:
  Handle the case of illegal values in the Cookie name/value pair.
  
  Reported by: Dennis Cartier <de...@canadianblackbook.com>
  
  Revision  Changes    Path
  1.15      +12 -6     jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteAdapter.java
  
  Index: CoyoteAdapter.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteAdapter.java,v
  retrieving revision 1.14
  retrieving revision 1.15
  diff -u -r1.14 -r1.15
  --- CoyoteAdapter.java	18 Feb 2003 22:51:39 -0000	1.14
  +++ CoyoteAdapter.java	12 Mar 2003 07:41:04 -0000	1.15
  @@ -353,6 +353,7 @@
   
           Cookie[] cookies = new Cookie[count];
   
  +	int idx=0;
           for (int i = 0; i < count; i++) {
               ServerCookie scookie = serverCookies.getCookie(i);
               if (scookie.getName().equals(Globals.SESSION_COOKIE_NAME)) {
  @@ -369,9 +370,14 @@
                               .getRequestedSessionId());
                   }
               }
  -            Cookie cookie = new Cookie(scookie.getName().toString(),
  +	    try {
  +		Cookie cookie = new Cookie(scookie.getName().toString(),
                                          scookie.getValue().toString());
  -            cookies[i] = cookie;
  +		cookies[idx++] = cookie;
  +	    } catch (Exception ex) {
  +		log("Bad Cookie Name: " + scookie.getName() + 
  +		    " /Value: " + scookie.getValue(),ex);
  +	    }
           }
   
           request.setCookies(cookies);
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org