[PR] Breeze: fail fast when building provider sdists from a git worktree [airflow]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk opened a new pull request, #65771:
URL: https://github.com/apache/airflow/pull/65771

   `breeze release-management prepare-provider-distributions` now exits
   early with a clear error if it is run from a `git worktree add ...`
   directory and would produce an sdist.
   
   **Why:** `flit --use-vcs` (used to build most provider sdists) relies on
   `flit.vcs.identify_vcs`, which checks `(p / ".git").is_dir()`. In a
   worktree `.git` is a *file* (`gitdir:` pointer), not a directory, so
   flit silently falls back to a minimal sdist that omits `docs/`,
   `tests/`, `provider.yaml` and other tracked files. The resulting
   packages differ from released sdists on dist.apache.org and fail
   reproducibility checks — with no warning from flit.
   
   This surfaced while running the PMC verification for the 2026-04-21
   provider RC from a worktree: all 47 wheels matched byte-for-byte, and
   the 3 providers that use hatchling with explicit `[tool.hatch.build.
   targets.sdist]` includes matched, but all 20 flit-based sdists diverged.
   
   **Scope of the check:**
   - `--distribution-format sdist` / `both` from a worktree → exits 1 with
     a clear message pointing at the flit issue and the two workarounds
     (plain `git checkout`, or `--distribution-format wheel`).
   - `--distribution-format wheel` from a worktree → unchanged (wheels are
     not affected by this flit bug).
   - Any format from a plain checkout → unchanged.
   
   Includes unit tests covering all four paths. Upstream flit tracking:
   `flit/vcs/__init__.py` `identify_vcs`.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Opus 4.7
   
   Generated-by: Claude Opus 4.7 following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Breeze: fail fast when building provider sdists from a git worktree [airflow]

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on PR #65771:
URL: https://github.com/apache/airflow/pull/65771#issuecomment-4316768618

   ### Backport successfully created: v3-2-test
   
   Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
   the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
   
   In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
   
   <table>
           <tr>
           <th>Status</th>
           <th>Branch</th>
           <th>Result</th>
       </tr>
       <tr>
           <td>✅</td>
           <td>v3-2-test</td>
           <td><a href="https://github.com/apache/airflow/pull/65828"><img src="https://img.shields.io/badge/PR-65828-blue" alt="PR Link"></a></td>
       </tr>
   </table>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Breeze: fail fast when building provider sdists from a git worktree [airflow]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk merged PR #65771:
URL: https://github.com/apache/airflow/pull/65771


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org