You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Saksham Srivastava <sa...@citrix.com> on 2014/05/07 14:22:51 UTC
Review Request 21156: CLOUDSTACK-6575: Deploy VM failed with NPE while using
custom compute offering
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21156/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh and Rajesh Battala.
Bugs: CLOUDSTACK-6575
https://issues.apache.org/jira/browse/CLOUDSTACK-6575
Repository: cloudstack-git
Description
-------
Deploy VM failed with NPE while using custom compute offering:
Steps to reproduce:
1. Install and configure Adv zone.
2. Create Compute offering with Custom option enabled.
3. Deploy VM using Default Cent OS template using Custom option enabled Compute offering.
Root Cause:
In schema-410to420.sql ALTER TABLE `cloud`.`disk_offering` ADD COLUMN `customized_iops` tinyint(1) unsigned COMMENT 'Should customized IOPS be displayed to the end user';
The default value of customized_iops is null and ServiceOfferingVO construtor calls the super constructor in DiskOfferingVO passing null to boolean value, hence the NPE.
Fix: Change Boolean to boolean with appropriate conversions.
Diffs
-----
engine/schema/src/com/cloud/service/ServiceOfferingVO.java 3be0aaa
Diff: https://reviews.apache.org/r/21156/diff/
Testing
-------
Deployed vm with customized_iops as null in disk_offering table.
Deployed vm with customized_iops as not null in disk_offering table.
Both the deployments pass.
Build passes successfully.
Thanks,
Saksham Srivastava
Re: Review Request 21156: CLOUDSTACK-6575: Deploy VM failed with NPE while
using custom compute offering
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21156/#review42463
-----------------------------------------------------------
Commit 84135cd302ab5fb944a28e73b394d02a8d1c17e2 in cloudstack's branch refs/heads/4.4-forward from Saksham Srivastava
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=84135cd ]
CLOUDSTACK-6575: Deploy VM failed with NPE while using custom compute offering
- ASF Subversion and Git Services
On May 7, 2014, 12:22 p.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21156/
> -----------------------------------------------------------
>
> (Updated May 7, 2014, 12:22 p.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6575
> https://issues.apache.org/jira/browse/CLOUDSTACK-6575
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Deploy VM failed with NPE while using custom compute offering:
> Steps to reproduce:
> 1. Install and configure Adv zone.
> 2. Create Compute offering with Custom option enabled.
> 3. Deploy VM using Default Cent OS template using Custom option enabled Compute offering.
>
> Root Cause:
> In schema-410to420.sql ALTER TABLE `cloud`.`disk_offering` ADD COLUMN `customized_iops` tinyint(1) unsigned COMMENT 'Should customized IOPS be displayed to the end user';
>
> The default value of customized_iops is null and ServiceOfferingVO construtor calls the super constructor in DiskOfferingVO passing null to boolean value, hence the NPE.
>
> Fix: Change Boolean to boolean with appropriate conversions.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/service/ServiceOfferingVO.java 3be0aaa
>
> Diff: https://reviews.apache.org/r/21156/diff/
>
>
> Testing
> -------
>
> Deployed vm with customized_iops as null in disk_offering table.
> Deployed vm with customized_iops as not null in disk_offering table.
> Both the deployments pass.
> Build passes successfully.
>
>
> Thanks,
>
> Saksham Srivastava
>
>
Re: Review Request 21156: CLOUDSTACK-6575: Deploy VM failed with NPE while
using custom compute offering
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21156/#review42462
-----------------------------------------------------------
Ship it!
Ship It!
- Rajesh Battala
On May 7, 2014, 12:22 p.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21156/
> -----------------------------------------------------------
>
> (Updated May 7, 2014, 12:22 p.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6575
> https://issues.apache.org/jira/browse/CLOUDSTACK-6575
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Deploy VM failed with NPE while using custom compute offering:
> Steps to reproduce:
> 1. Install and configure Adv zone.
> 2. Create Compute offering with Custom option enabled.
> 3. Deploy VM using Default Cent OS template using Custom option enabled Compute offering.
>
> Root Cause:
> In schema-410to420.sql ALTER TABLE `cloud`.`disk_offering` ADD COLUMN `customized_iops` tinyint(1) unsigned COMMENT 'Should customized IOPS be displayed to the end user';
>
> The default value of customized_iops is null and ServiceOfferingVO construtor calls the super constructor in DiskOfferingVO passing null to boolean value, hence the NPE.
>
> Fix: Change Boolean to boolean with appropriate conversions.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/service/ServiceOfferingVO.java 3be0aaa
>
> Diff: https://reviews.apache.org/r/21156/diff/
>
>
> Testing
> -------
>
> Deployed vm with customized_iops as null in disk_offering table.
> Deployed vm with customized_iops as not null in disk_offering table.
> Both the deployments pass.
> Build passes successfully.
>
>
> Thanks,
>
> Saksham Srivastava
>
>
Re: Review Request 21156: CLOUDSTACK-6575: Deploy VM failed with NPE while
using custom compute offering
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21156/#review42640
-----------------------------------------------------------
Commit 3943e0ba1c6fc343ac928980bb7309c7256b4e8e in cloudstack's branch refs/heads/4.4 from Saksham Srivastava
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3943e0b ]
CLOUDSTACK-6575: Deploy VM failed with NPE while using custom compute offering
- ASF Subversion and Git Services
On May 7, 2014, 12:22 p.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21156/
> -----------------------------------------------------------
>
> (Updated May 7, 2014, 12:22 p.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6575
> https://issues.apache.org/jira/browse/CLOUDSTACK-6575
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Deploy VM failed with NPE while using custom compute offering:
> Steps to reproduce:
> 1. Install and configure Adv zone.
> 2. Create Compute offering with Custom option enabled.
> 3. Deploy VM using Default Cent OS template using Custom option enabled Compute offering.
>
> Root Cause:
> In schema-410to420.sql ALTER TABLE `cloud`.`disk_offering` ADD COLUMN `customized_iops` tinyint(1) unsigned COMMENT 'Should customized IOPS be displayed to the end user';
>
> The default value of customized_iops is null and ServiceOfferingVO construtor calls the super constructor in DiskOfferingVO passing null to boolean value, hence the NPE.
>
> Fix: Change Boolean to boolean with appropriate conversions.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/service/ServiceOfferingVO.java 3be0aaa
>
> Diff: https://reviews.apache.org/r/21156/diff/
>
>
> Testing
> -------
>
> Deployed vm with customized_iops as null in disk_offering table.
> Deployed vm with customized_iops as not null in disk_offering table.
> Both the deployments pass.
> Build passes successfully.
>
>
> Thanks,
>
> Saksham Srivastava
>
>
Re: Review Request 21156: CLOUDSTACK-6575: Deploy VM failed with NPE while
using custom compute offering
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21156/#review42464
-----------------------------------------------------------
Commit b8adb96ae1d1ce0066ce8c937fa0e15434c4acc4 in cloudstack's branch refs/heads/master from Saksham Srivastava
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b8adb96 ]
CLOUDSTACK-6575: Deploy VM failed with NPE while using custom compute offering
- ASF Subversion and Git Services
On May 7, 2014, 12:22 p.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21156/
> -----------------------------------------------------------
>
> (Updated May 7, 2014, 12:22 p.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6575
> https://issues.apache.org/jira/browse/CLOUDSTACK-6575
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Deploy VM failed with NPE while using custom compute offering:
> Steps to reproduce:
> 1. Install and configure Adv zone.
> 2. Create Compute offering with Custom option enabled.
> 3. Deploy VM using Default Cent OS template using Custom option enabled Compute offering.
>
> Root Cause:
> In schema-410to420.sql ALTER TABLE `cloud`.`disk_offering` ADD COLUMN `customized_iops` tinyint(1) unsigned COMMENT 'Should customized IOPS be displayed to the end user';
>
> The default value of customized_iops is null and ServiceOfferingVO construtor calls the super constructor in DiskOfferingVO passing null to boolean value, hence the NPE.
>
> Fix: Change Boolean to boolean with appropriate conversions.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/service/ServiceOfferingVO.java 3be0aaa
>
> Diff: https://reviews.apache.org/r/21156/diff/
>
>
> Testing
> -------
>
> Deployed vm with customized_iops as null in disk_offering table.
> Deployed vm with customized_iops as not null in disk_offering table.
> Both the deployments pass.
> Build passes successfully.
>
>
> Thanks,
>
> Saksham Srivastava
>
>