You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2018/10/08 14:41:03 UTC

[GitHub] simonetripodi opened a new pull request #5: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin

simonetripodi opened a new pull request #5: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5
 
 
   Hi there @bosschaert,
   please have a look at the initial implementation of my proposal.
   
   I moved few utility static methods from Analyzer class to a proper dedicated Task provider implementation, in order to have separation of concerns and better unit testing.
   
   I also implemented a new unit test, all old tests still pass.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services