You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by sanjeev n <sa...@citrix.com> on 2014/09/03 11:58:50 UTC

Review Request 25293: Test script to verify vm deployment with two networks in SG enabled advanced zone

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25293/
-----------------------------------------------------------

Review request for cloudstack, suresh sadhu, Santhosh Edukulla, and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
-------

Test script to verify vm deployment with two networks in SG enabled advanced zone.
Involves following steps:
1.Deploy SG enabled advanced zone with only 4 ip addresses in guest ip range using simulator
2.Deploy one guest vm in the default shared guest network so that all the IP addresses will be consumed
3.Add another guest network in the zone created at step1
4.Deploy vm without passing the network id. It should pick the network with sufficient resources


Diffs
-----

  test/integration/component/test_advancedsg_networks.py 85ab697 
  tools/marvin/marvin/config/test_data.py b658b01 

Diff: https://reviews.apache.org/r/25293/diff/


Testing
-------

@Desc: VM Cannot deploy to second network in advanced SG network ... === TestName: test_34_DeployVM_in_SecondSGNetwork | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 1 test in 343.198s

OK


Thanks,

sanjeev n


Re: Review Request 25293: Test script to verify vm deployment with two networks in SG enabled advanced zone

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25293/#review54665
-----------------------------------------------------------

Ship it!


Ship It!

- SrikanteswaraRao Talluri


On Sept. 26, 2014, 10:15 a.m., sanjeev n wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25293/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2014, 10:15 a.m.)
> 
> 
> Review request for cloudstack, suresh sadhu, Santhosh Edukulla, and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Test script to verify vm deployment with two networks in SG enabled advanced zone.
> Involves following steps:
> 1.Deploy SG enabled advanced zone with only 4 ip addresses in guest ip range using simulator
> 2.Deploy one guest vm in the default shared guest network so that all the IP addresses will be consumed
> 3.Add another guest network in the zone created at step1
> 4.Deploy vm without passing the network id. It should pick the network with sufficient resources
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_advancedsg_networks.py 85ab697 
>   tools/marvin/marvin/config/test_data.py b658b01 
> 
> Diff: https://reviews.apache.org/r/25293/diff/
> 
> 
> Testing
> -------
> 
> @Desc: VM Cannot deploy to second network in advanced SG network ... === TestName: test_34_DeployVM_in_SecondSGNetwork | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 343.198s
> 
> OK
> 
> 
> Thanks,
> 
> sanjeev n
> 
>


Re: Review Request 25293: Test script to verify vm deployment with two networks in SG enabled advanced zone

Posted by sanjeev n <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25293/
-----------------------------------------------------------

(Updated Sept. 26, 2014, 10:15 a.m.)


Review request for cloudstack, suresh sadhu, Santhosh Edukulla, and SrikanteswaraRao Talluri.


Changes
-------

Incorporated review comments


Repository: cloudstack-git


Description
-------

Test script to verify vm deployment with two networks in SG enabled advanced zone.
Involves following steps:
1.Deploy SG enabled advanced zone with only 4 ip addresses in guest ip range using simulator
2.Deploy one guest vm in the default shared guest network so that all the IP addresses will be consumed
3.Add another guest network in the zone created at step1
4.Deploy vm without passing the network id. It should pick the network with sufficient resources


Diffs (updated)
-----

  test/integration/component/test_advancedsg_networks.py 85ab697 
  tools/marvin/marvin/config/test_data.py b658b01 

Diff: https://reviews.apache.org/r/25293/diff/


Testing
-------

@Desc: VM Cannot deploy to second network in advanced SG network ... === TestName: test_34_DeployVM_in_SecondSGNetwork | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 1 test in 343.198s

OK


Thanks,

sanjeev n


Re: Review Request 25293: Test script to verify vm deployment with two networks in SG enabled advanced zone

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25293/#review52868
-----------------------------------------------------------



test/integration/component/test_advancedsg_networks.py
<https://reviews.apache.org/r/25293/#comment92027>

    it is better to have a condition for windows and then final else for "other OS"



tools/marvin/marvin/config/test_data.py
<https://reviews.apache.org/r/25293/#comment92026>

    it would be nice to point to where/how we can get a sample advancedsg.cfg file


- SrikanteswaraRao Talluri


On Sept. 3, 2014, 9:58 a.m., sanjeev n wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25293/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2014, 9:58 a.m.)
> 
> 
> Review request for cloudstack, suresh sadhu, Santhosh Edukulla, and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Test script to verify vm deployment with two networks in SG enabled advanced zone.
> Involves following steps:
> 1.Deploy SG enabled advanced zone with only 4 ip addresses in guest ip range using simulator
> 2.Deploy one guest vm in the default shared guest network so that all the IP addresses will be consumed
> 3.Add another guest network in the zone created at step1
> 4.Deploy vm without passing the network id. It should pick the network with sufficient resources
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_advancedsg_networks.py 85ab697 
>   tools/marvin/marvin/config/test_data.py b658b01 
> 
> Diff: https://reviews.apache.org/r/25293/diff/
> 
> 
> Testing
> -------
> 
> @Desc: VM Cannot deploy to second network in advanced SG network ... === TestName: test_34_DeployVM_in_SecondSGNetwork | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 343.198s
> 
> OK
> 
> 
> Thanks,
> 
> sanjeev n
> 
>


Re: Review Request 25293: Test script to verify vm deployment with two networks in SG enabled advanced zone

Posted by suresh sadhu <ma...@gmail.com>.

> On Sept. 4, 2014, 4:05 a.m., suresh sadhu wrote:
> > Ship It!

addressed the preview  review comments and looks good to me.


- suresh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25293/#review52275
-----------------------------------------------------------


On Sept. 3, 2014, 9:58 a.m., sanjeev n wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25293/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2014, 9:58 a.m.)
> 
> 
> Review request for cloudstack, suresh sadhu, Santhosh Edukulla, and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Test script to verify vm deployment with two networks in SG enabled advanced zone.
> Involves following steps:
> 1.Deploy SG enabled advanced zone with only 4 ip addresses in guest ip range using simulator
> 2.Deploy one guest vm in the default shared guest network so that all the IP addresses will be consumed
> 3.Add another guest network in the zone created at step1
> 4.Deploy vm without passing the network id. It should pick the network with sufficient resources
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_advancedsg_networks.py 85ab697 
>   tools/marvin/marvin/config/test_data.py b658b01 
> 
> Diff: https://reviews.apache.org/r/25293/diff/
> 
> 
> Testing
> -------
> 
> @Desc: VM Cannot deploy to second network in advanced SG network ... === TestName: test_34_DeployVM_in_SecondSGNetwork | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 343.198s
> 
> OK
> 
> 
> Thanks,
> 
> sanjeev n
> 
>


Re: Review Request 25293: Test script to verify vm deployment with two networks in SG enabled advanced zone

Posted by suresh sadhu <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25293/#review52275
-----------------------------------------------------------

Ship it!


Ship It!

- suresh sadhu


On Sept. 3, 2014, 9:58 a.m., sanjeev n wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25293/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2014, 9:58 a.m.)
> 
> 
> Review request for cloudstack, suresh sadhu, Santhosh Edukulla, and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Test script to verify vm deployment with two networks in SG enabled advanced zone.
> Involves following steps:
> 1.Deploy SG enabled advanced zone with only 4 ip addresses in guest ip range using simulator
> 2.Deploy one guest vm in the default shared guest network so that all the IP addresses will be consumed
> 3.Add another guest network in the zone created at step1
> 4.Deploy vm without passing the network id. It should pick the network with sufficient resources
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_advancedsg_networks.py 85ab697 
>   tools/marvin/marvin/config/test_data.py b658b01 
> 
> Diff: https://reviews.apache.org/r/25293/diff/
> 
> 
> Testing
> -------
> 
> @Desc: VM Cannot deploy to second network in advanced SG network ... === TestName: test_34_DeployVM_in_SecondSGNetwork | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 343.198s
> 
> OK
> 
> 
> Thanks,
> 
> sanjeev n
> 
>