You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/12/11 01:54:22 UTC
[GitHub] timifasubaa commented on a change in pull request #6497: pass
source to db api mutator
timifasubaa commented on a change in pull request #6497: pass source to db api mutator
URL: https://github.com/apache/incubator-superset/pull/6497#discussion_r240449141
##########
File path: superset/utils/core.py
##########
@@ -54,6 +54,12 @@
JS_MAX_INTEGER = 9007199254740991 # Largest int Java Script can handle 2^53-1
+sources = {
Review comment:
I see what you're saying. I was thinking of this more as an Enum in Java so I made the callers set none as the default instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org