[jira] [Commented] (FLINK-6157) Make TypeInformation fully serializable

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989853#comment-15989853 ] 

ASF GitHub Bot commented on FLINK-6157:
---------------------------------------

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/3619
  
    +1 LGTM.
    
    My only thought is if a user passes test data with more than one implementation of `TypeInformation` (and passing the `canEquals` test) then the check for `hashCode` and `equals` would only run on the first instance.


> Make TypeInformation fully serializable
> ---------------------------------------
>
>                 Key: FLINK-6157
>                 URL: https://issues.apache.org/jira/browse/FLINK-6157
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>
> TypeInformation is already declared serializable, however, there are no tests that verify that all classes are really serializable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)