You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2017/03/21 17:34:53 UTC
Review Request 57813: Service quick links not showing up in the UI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57813/
-----------------------------------------------------------
Review request for Ambari, Aleksandr Kovalenko and Jaimin Jetly.
Bugs: AMBARI-20521
https://issues.apache.org/jira/browse/AMBARI-20521
Repository: ambari
Description
-------
STR:
Create a Kafka cluster with Kafka brokers on 64 hosts (or any cluster with master components hosted on 64 separate hosts)
Navigate to any service on ambari-web that has quicklinks
Actual Result: Quick links are incorrectly absent
Expected Result: Quick links should be shown
Diffs
-----
ambari-web/app/utils/ajax/ajax.js b856e44
ambari-web/test/utils/ajax/ajax_test.js 35de05f
Diff: https://reviews.apache.org/r/57813/diff/1/
Testing
-------
30380 passing (38s)
157 pending
Thanks,
Andrii Tkach
Re: Review Request 57813: Service quick links not showing up in the UI
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57813/#review169607
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On March 21, 2017, 5:34 p.m., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57813/
> -----------------------------------------------------------
>
> (Updated March 21, 2017, 5:34 p.m.)
>
>
> Review request for Ambari, Aleksandr Kovalenko and Jaimin Jetly.
>
>
> Bugs: AMBARI-20521
> https://issues.apache.org/jira/browse/AMBARI-20521
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> Create a Kafka cluster with Kafka brokers on 64 hosts (or any cluster with master components hosted on 64 separate hosts)
> Navigate to any service on ambari-web that has quicklinks
> Actual Result: Quick links are incorrectly absent
> Expected Result: Quick links should be shown
>
>
> Diffs
> -----
>
> ambari-web/app/utils/ajax/ajax.js b856e44
> ambari-web/test/utils/ajax/ajax_test.js 35de05f
>
>
> Diff: https://reviews.apache.org/r/57813/diff/1/
>
>
> Testing
> -------
>
> 30380 passing (38s)
> 157 pending
>
>
> Thanks,
>
> Andrii Tkach
>
>
Re: Review Request 57813: Service quick links not showing up in the UI
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57813/#review169700
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On \u041c\u0430\u0440\u0442 22, 2017, 11:13 \u0434.\u043f., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57813/
> -----------------------------------------------------------
>
> (Updated \u041c\u0430\u0440\u0442 22, 2017, 11:13 \u0434.\u043f.)
>
>
> Review request for Ambari, Aleksandr Kovalenko and Jaimin Jetly.
>
>
> Bugs: AMBARI-20521
> https://issues.apache.org/jira/browse/AMBARI-20521
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> Create a Kafka cluster with Kafka brokers on 64 hosts (or any cluster with master components hosted on 64 separate hosts)
> Navigate to any service on ambari-web that has quicklinks
> Actual Result: Quick links are incorrectly absent
> Expected Result: Quick links should be shown
>
>
> Diffs
> -----
>
> ambari-web/app/utils/ajax/ajax.js b856e44
> ambari-web/test/utils/ajax/ajax_test.js 35de05f
>
>
> Diff: https://reviews.apache.org/r/57813/diff/2/
>
>
> Testing
> -------
>
> 30380 passing (38s)
> 157 pending
>
>
> Thanks,
>
> Andrii Tkach
>
>
Re: Review Request 57813: Service quick links not showing up in the UI
Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57813/
-----------------------------------------------------------
(Updated March 22, 2017, 11:13 a.m.)
Review request for Ambari, Aleksandr Kovalenko and Jaimin Jetly.
Bugs: AMBARI-20521
https://issues.apache.org/jira/browse/AMBARI-20521
Repository: ambari
Description
-------
STR:
Create a Kafka cluster with Kafka brokers on 64 hosts (or any cluster with master components hosted on 64 separate hosts)
Navigate to any service on ambari-web that has quicklinks
Actual Result: Quick links are incorrectly absent
Expected Result: Quick links should be shown
Diffs (updated)
-----
ambari-web/app/utils/ajax/ajax.js b856e44
ambari-web/test/utils/ajax/ajax_test.js 35de05f
Diff: https://reviews.apache.org/r/57813/diff/2/
Changes: https://reviews.apache.org/r/57813/diff/1-2/
Testing
-------
30380 passing (38s)
157 pending
Thanks,
Andrii Tkach
Re: Review Request 57813: Service quick links not showing up in the UI
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57813/#review169600
-----------------------------------------------------------
ambari-web/app/utils/ajax/ajax.js
Line 3059 (original), 3060 (patched)
<https://reviews.apache.org/r/57813/#comment242040>
Although it does not have any impact in API response as of now but lets not append "fields" and "minimal_response" param in the data body also.
ambari-web/app/utils/ajax/ajax.js
Lines 3061-3063 (original), 3062-3066 (patched)
<https://reviews.apache.org/r/57813/#comment242039>
only if '&fields' param is present in the url then lets append opt.url = '&_=' + App.datetime instead of '?_='
- Jaimin Jetly
On March 21, 2017, 5:34 p.m., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57813/
> -----------------------------------------------------------
>
> (Updated March 21, 2017, 5:34 p.m.)
>
>
> Review request for Ambari, Aleksandr Kovalenko and Jaimin Jetly.
>
>
> Bugs: AMBARI-20521
> https://issues.apache.org/jira/browse/AMBARI-20521
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> Create a Kafka cluster with Kafka brokers on 64 hosts (or any cluster with master components hosted on 64 separate hosts)
> Navigate to any service on ambari-web that has quicklinks
> Actual Result: Quick links are incorrectly absent
> Expected Result: Quick links should be shown
>
>
> Diffs
> -----
>
> ambari-web/app/utils/ajax/ajax.js b856e44
> ambari-web/test/utils/ajax/ajax_test.js 35de05f
>
>
> Diff: https://reviews.apache.org/r/57813/diff/1/
>
>
> Testing
> -------
>
> 30380 passing (38s)
> 157 pending
>
>
> Thanks,
>
> Andrii Tkach
>
>