You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by fh...@apache.org on 2007/09/27 16:49:46 UTC

svn commit: r580038 - in /tomcat/sandbox/gdev6x: java/org/apache/catalina/valves/AccessLogValve.java webapps/docs/config/valve.xml

Author: fhanik
Date: Thu Sep 27 07:49:45 2007
New Revision: 580038

URL: http://svn.apache.org/viewvc?rev=580038&view=rev
Log:
forward port from 6.0

Modified:
    tomcat/sandbox/gdev6x/java/org/apache/catalina/valves/AccessLogValve.java
    tomcat/sandbox/gdev6x/webapps/docs/config/valve.xml

Modified: tomcat/sandbox/gdev6x/java/org/apache/catalina/valves/AccessLogValve.java
URL: http://svn.apache.org/viewvc/tomcat/sandbox/gdev6x/java/org/apache/catalina/valves/AccessLogValve.java?rev=580038&r1=580037&r2=580038&view=diff
==============================================================================
--- tomcat/sandbox/gdev6x/java/org/apache/catalina/valves/AccessLogValve.java (original)
+++ tomcat/sandbox/gdev6x/java/org/apache/catalina/valves/AccessLogValve.java Thu Sep 27 07:49:45 2007
@@ -43,6 +43,7 @@
 import org.apache.catalina.connector.Response;
 import org.apache.catalina.util.LifecycleSupport;
 import org.apache.catalina.util.StringManager;
+import org.apache.coyote.RequestInfo;
 import org.apache.juli.logging.Log;
 import org.apache.juli.logging.LogFactory;
 
@@ -79,6 +80,7 @@
  * <li><b>%v</b> - Local server name
  * <li><b>%D</b> - Time taken to process the request, in millis
  * <li><b>%T</b> - Time taken to process the request, in seconds
+ * <li><b>%I</b> - current Request thread name (can compare later with stacktraces)
  * </ul>
  * <p>In addition, the caller can specify one of the following aliases for
  * commonly utilized patterns:</p>
@@ -890,6 +892,7 @@
                     .getString("accessLogValve.notStarted"));
         lifecycle.fireLifecycleEvent(STOP_EVENT, null);
         started = false;
+        
         close();
     }
     
@@ -903,6 +906,21 @@
     }
     
     /**
+     * write thread name - %I
+     */
+    protected class ThreadNameElement implements AccessLogElement {
+        public void addElement(StringBuffer buf, Date date, Request request,
+                Response response, long time) {
+            RequestInfo info = request.getCoyoteRequest().getRequestProcessor();
+            if(info != null) {
+                buf.append(info.getWorkerThreadName());
+            } else {
+                buf.append("-");
+            }
+        }
+    }
+    
+    /**
      * write local IP address - %A
      */
     protected class LocalAddrElement implements AccessLogElement {
@@ -1422,6 +1440,8 @@
             return new RequestURIElement();
         case 'v':
             return new LocalServerNameElement();
+        case 'I':
+            return new ThreadNameElement();
         default:
             return new StringElement("???" + pattern + "???");
         }

Modified: tomcat/sandbox/gdev6x/webapps/docs/config/valve.xml
URL: http://svn.apache.org/viewvc/tomcat/sandbox/gdev6x/webapps/docs/config/valve.xml?rev=580038&r1=580037&r2=580038&view=diff
==============================================================================
--- tomcat/sandbox/gdev6x/webapps/docs/config/valve.xml (original)
+++ tomcat/sandbox/gdev6x/webapps/docs/config/valve.xml Thu Sep 27 07:49:45 2007
@@ -163,6 +163,7 @@
     <li><b>%v</b> - Local server name</li>
     <li><b>%D</b> - Time taken to process the request, in millis</li>
     <li><b>%T</b> - Time taken to process the request, in seconds</li>
+    <li><b>%I</b> - current request thread name (can compare later with stacktraces)</li>
     </ul>
 
     <p>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org