You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Eric Wadsworth <er...@wadhome.org> on 2011/12/19 23:37:42 UTC
Review Request: Uppercase table name and table owner name.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3266/
-----------------------------------------------------------
Review request for Sqoop.
Summary
-------
Uppercase table name and table owner name
This addresses bug https://issues.apache.org/jira/browse/SQOOP-415.
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-415
Diffs
-----
/src/java/org/apache/sqoop/manager/OracleManager.java 1220973
Diff: https://reviews.apache.org/r/3266/diff
Testing
-------
Did not add any unit testing for this. Before the patch, sqoop fails for me when connecting to oracle. When built with this patch, it works. "ant test" passes.
Thanks,
Eric
Re: Review Request: Uppercase table name and table owner name.
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3266/#review4003
-----------------------------------------------------------
[Added this comment to the JIRA as well]
Eric, the OracleManager uses catalog queries for looking up metadata which requires case sensitive sepcification of user name and table name. If the user/table name was not quoted at the time of creation, Oracle by default converts them to upper case and hence you see this problem. It is also documented in the troubleshooting guide [1].
One way to alleviate this problem is to do modify Sqoop behavior so as to mimic Oracle's handling of such literals. In other words, if the specified user/table name is not quoted, Sqoop should convert them to upper case. If they are quoted, they should remain as specified.
[1] http://incubator.apache.org/sqoop/docs/1.4.0-incubating/SqoopUserGuide.html#id1774574
- Arvind
On 2011-12-19 22:37:41, Eric Wadsworth wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3266/
> -----------------------------------------------------------
>
> (Updated 2011-12-19 22:37:41)
>
>
> Review request for Sqoop.
>
>
> Summary
> -------
>
> Uppercase table name and table owner name
>
>
> This addresses bug https://issues.apache.org/jira/browse/SQOOP-415.
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-415
>
>
> Diffs
> -----
>
> /src/java/org/apache/sqoop/manager/OracleManager.java 1220973
>
> Diff: https://reviews.apache.org/r/3266/diff
>
>
> Testing
> -------
>
> Did not add any unit testing for this. Before the patch, sqoop fails for me when connecting to oracle. When built with this patch, it works. "ant test" passes.
>
>
> Thanks,
>
> Eric
>
>
Re: Review Request: Uppercase table name and table owner name.
Posted by Eric Wadsworth <er...@wadhome.org>.
> On 2011-12-28 07:43:54, Arvind Prabhakar wrote:
> > Eric - thanks for the patch. Were you able to successfully import data from a table with mixed/lower case name? When I tried out your change, I ran into https://issues.apache.org/jira/browse/CLI-185 which is fixed for 1.3 release of Commons-CLI but there does not seem to be an ETA on that release yet.
Arvind,
Thanks for looking at the patch!
That CLI-195 looks like a mess, I wish I hadn't stepped in it. I'm going to do some more testing around this patch.
--- wad
- Eric
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3266/#review4133
-----------------------------------------------------------
On 2011-12-21 19:03:52, Eric Wadsworth wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3266/
> -----------------------------------------------------------
>
> (Updated 2011-12-21 19:03:52)
>
>
> Review request for Sqoop.
>
>
> Summary
> -------
>
> Uppercase table name and table owner name if it's not surrounded by double quotes.
>
>
> This addresses bug SQOOP-415.
> https://issues.apache.org/jira/browse/SQOOP-415
>
>
> Diffs
> -----
>
> /src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 1221519
> /src/java/org/apache/sqoop/manager/OracleManager.java 1221519
>
> Diff: https://reviews.apache.org/r/3266/diff
>
>
> Testing
> -------
>
> This patch includes a unit test. Before the patch, sqoop fails for me when connecting to oracle. When built with this patch, it works. "ant test" passes.
>
>
> Thanks,
>
> Eric
>
>
Re: Review Request: Uppercase table name and table owner name.
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3266/#review4133
-----------------------------------------------------------
Eric - thanks for the patch. Were you able to successfully import data from a table with mixed/lower case name? When I tried out your change, I ran into https://issues.apache.org/jira/browse/CLI-185 which is fixed for 1.3 release of Commons-CLI but there does not seem to be an ETA on that release yet.
- Arvind
On 2011-12-21 19:03:52, Eric Wadsworth wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3266/
> -----------------------------------------------------------
>
> (Updated 2011-12-21 19:03:52)
>
>
> Review request for Sqoop.
>
>
> Summary
> -------
>
> Uppercase table name and table owner name if it's not surrounded by double quotes.
>
>
> This addresses bug SQOOP-415.
> https://issues.apache.org/jira/browse/SQOOP-415
>
>
> Diffs
> -----
>
> /src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 1221519
> /src/java/org/apache/sqoop/manager/OracleManager.java 1221519
>
> Diff: https://reviews.apache.org/r/3266/diff
>
>
> Testing
> -------
>
> This patch includes a unit test. Before the patch, sqoop fails for me when connecting to oracle. When built with this patch, it works. "ant test" passes.
>
>
> Thanks,
>
> Eric
>
>
Re: Review Request: Uppercase table name and table owner name.
Posted by Eric Wadsworth <er...@wadhome.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3266/
-----------------------------------------------------------
(Updated 2011-12-21 19:03:52.238073)
Review request for Sqoop.
Changes
-------
Removed the original patch I had submitted, and replaced it with a new one. This one checks for double-quotes around oracle table names and owner names, and uppercases them if they aren't quoted.
Summary (updated)
-------
Uppercase table name and table owner name if it's not surrounded by double quotes.
This addresses bug SQOOP-415.
https://issues.apache.org/jira/browse/SQOOP-415
Diffs (updated)
-----
/src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 1221519
/src/java/org/apache/sqoop/manager/OracleManager.java 1221519
Diff: https://reviews.apache.org/r/3266/diff
Testing (updated)
-------
This patch includes a unit test. Before the patch, sqoop fails for me when connecting to oracle. When built with this patch, it works. "ant test" passes.
Thanks,
Eric
Re: Review Request: Uppercase table name and table owner name.
Posted by Eric Wadsworth <er...@wadhome.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3266/
-----------------------------------------------------------
(Updated 2011-12-20 17:54:17.588744)
Review request for Sqoop.
Summary
-------
Uppercase table name and table owner name
This addresses bug SQOOP-415.
https://issues.apache.org/jira/browse/SQOOP-415
Diffs
-----
/src/java/org/apache/sqoop/manager/OracleManager.java 1220973
Diff: https://reviews.apache.org/r/3266/diff
Testing
-------
Did not add any unit testing for this. Before the patch, sqoop fails for me when connecting to oracle. When built with this patch, it works. "ant test" passes.
Thanks,
Eric
Re: Review Request: Uppercase table name and table owner name.
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3266/#review4004
-----------------------------------------------------------
Please edit the "Bugs" field of the review and set it to SQOOP-415 instead of https://issues.apache.org/jira/browse/SQOOP-415. Once you do this, any comments posted on the review board will be automatically posted on the JIRA as well.
- Arvind
On 2011-12-19 22:37:41, Eric Wadsworth wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3266/
> -----------------------------------------------------------
>
> (Updated 2011-12-19 22:37:41)
>
>
> Review request for Sqoop.
>
>
> Summary
> -------
>
> Uppercase table name and table owner name
>
>
> This addresses bug https://issues.apache.org/jira/browse/SQOOP-415.
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-415
>
>
> Diffs
> -----
>
> /src/java/org/apache/sqoop/manager/OracleManager.java 1220973
>
> Diff: https://reviews.apache.org/r/3266/diff
>
>
> Testing
> -------
>
> Did not add any unit testing for this. Before the patch, sqoop fails for me when connecting to oracle. When built with this patch, it works. "ant test" passes.
>
>
> Thanks,
>
> Eric
>
>