You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/07 07:14:02 UTC
[GitHub] [incubator-doris-manager] wangyf0555 opened a new pull request, #34: [fix](frontend)fix bug with role list navigate to role detail page failure
wangyf0555 opened a new pull request, #34:
URL: https://github.com/apache/incubator-doris-manager/pull/34
# fix bug with role list navigate to role detail page failure
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris-manager] colordove commented on a diff in pull request #34: [fix](frontend)fix bug with role list navigate to role detail page failure
Posted by GitBox <gi...@apache.org>.
colordove commented on code in PR #34:
URL: https://github.com/apache/incubator-doris-manager/pull/34#discussion_r844798998
##########
frontend/src/routes/admin/people/role/member/member.tsx:
##########
@@ -33,7 +33,7 @@ import { useMatch } from 'react-router';
export function RoleMembers() {
const { t } = useTranslation();
- const match = useMatch('admin/role/:roleId');
+ const match = useMatch('admin/people/role/:roleId');
Review Comment:
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris-manager] hf200012 merged pull request #34: [fix](frontend)fix bug with role list navigate to role detail page failure
Posted by GitBox <gi...@apache.org>.
hf200012 merged PR #34:
URL: https://github.com/apache/incubator-doris-manager/pull/34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org