You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "lsergio (via GitHub)" <gi...@apache.org> on 2024/08/23 12:55:11 UTC
[I] Add ingressClassName field do Ingress trait [camel-k]
lsergio opened a new issue, #5793:
URL: https://github.com/apache/camel-k/issues/5793
### Requirement
The [Ingress spec](https://kubernetes.io/docs/reference/kubernetes-api/service-resources/ingress-v1/#IngressSpec) has the ingressClassName field which is a replacement for the [deprecated](https://kubernetes.io/docs/concepts/services-networking/ingress/#deprecated-annotation) `kubernetes.io/ingress.class` annotation.
I think it might be interesting to add the ingressClassName field to the Ingress trait to be compatible with recommended way of defining the class name.
### Problem
It doesn't really block me from creating the Ingress. It will be a problem if the deprecated annotation someday is removed from the k8s api.
### Proposal
Just add the field to the Ingress trait as a non-required information and copy it to the corresponding Ingress attribute.
### Open questions
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add ingressClassName field do Ingress trait [camel-k]
Posted by "lsergio (via GitHub)" <gi...@apache.org>.
lsergio commented on issue #5793:
URL: https://github.com/apache/camel-k/issues/5793#issuecomment-2307038516
I can work on that if it's a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add ingressClassName field to Ingress trait [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on issue #5793:
URL: https://github.com/apache/camel-k/issues/5793#issuecomment-2309530987
Yeah thanks, it would be great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add ingressClassName field to Ingress trait [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez closed issue #5793: Add ingressClassName field to Ingress trait
URL: https://github.com/apache/camel-k/issues/5793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org