You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mapleFU (via GitHub)" <gi...@apache.org> on 2023/07/12 16:53:36 UTC

[GitHub] [arrow] mapleFU opened a new pull request, #36647: GH-36643: [C++][{arquet] using nested namespace in parquet

mapleFU opened a new pull request, #36647:
URL: https://github.com/apache/arrow/pull/36647

   <!--
   Thanks for opening a pull request!
   If this is your first pull request you can find detailed information on how 
   to contribute here:
     * [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
     * [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
   
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
   
   Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename the pull request title in the following format?
   
       GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   In the case of PARQUET issues on JIRA the title also supports:
   
       PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   -->
   
   ### Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   Just for code style, using nested namespace rather than before
   
   ### What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   Using nested namespace
   
   ### Are these changes tested?
   
   no
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   ### Are there any user-facing changes?
   
   no
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
   -->
   <!-- **This PR includes breaking changes to public APIs.** -->
   
   <!--
   Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
   -->
   <!-- **This PR contains a "Critical Fix".** -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kou commented on a diff in pull request #36647: GH-36643: [C++][Parquet] Use nested namespace in parquet

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #36647:
URL: https://github.com/apache/arrow/pull/36647#discussion_r1262008058


##########
cpp/src/parquet/level_conversion_inc.h:
##########
@@ -30,8 +30,7 @@
 #include "parquet/exception.h"
 #include "parquet/level_comparison.h"
 
-namespace parquet {
-namespace internal {
+namespace parquet::internal {
 #ifndef PARQUET_IMPL_NAMESPACE
 #error "PARQUET_IMPL_NAMESPACE must be defined"
 #endif

Review Comment:
   We may want to use `namespace parquet::internal::PARQUET_IMPL_NAMESPACE`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou merged pull request #36647: GH-36643: [C++][Parquet] Use nested namespace in parquet

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #36647:
URL: https://github.com/apache/arrow/pull/36647


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on pull request #36647: GH-36643: [C++][Parquet] Use nested namespace in parquet

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #36647:
URL: https://github.com/apache/arrow/pull/36647#issuecomment-1634174744

   > Seems this doesn't caused by my patch https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/47536246 ?
   
   No, this build has been failing lately :-(
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #36647: GH-36643: [C++][{arquet] using nested namespace in parquet

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36647:
URL: https://github.com/apache/arrow/pull/36647#issuecomment-1632887413

   :warning: GitHub issue #36643 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36647: GH-36643: [C++][Parquet] Use nested namespace in parquet

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36647:
URL: https://github.com/apache/arrow/pull/36647#issuecomment-1646781746

   After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit c9fbc88eccd56fda27d6bc655732ed17388317ac.
   
   There were 3 benchmark results indicating a performance regression:
   
   - Commit Run on `ec2-m5-4xlarge-us-east-2` at [2023-07-13 13:25:57Z](http://conbench.ursa.dev/compare/runs/2cee4346a0eb4340b5a44783427cb3e9...edfa4fca804040ed977c302ffceb2ff5/)
     - [engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-06, scale_factor=10](http://conbench.ursa.dev/compare/benchmarks/064aff1720a87ced80002ad6e571a23a...064b003c4a37779d800069e15596b4e2)
   
   - Commit Run on `ursa-i9-9960x` at [2023-07-23 05:35:29Z](http://conbench.ursa.dev/compare/runs/c0d29323c6f5410daaeb5bec05050087...cc28691c79a14862a7b2f50a4eec263d/)
     - [engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-20, scale_factor=1](http://conbench.ursa.dev/compare/benchmarks/064bcaa5c13a71408000965ae9708436...064bcdc07ec17512800065bc8a7b7763)
   - and 1 more (see the report linked below)
   
   The [full Conbench report](https://github.com/apache/arrow/runs/15266501127) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] mapleFU commented on a diff in pull request #36647: GH-36643: [C++][Parquet] Use nested namespace in parquet

Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on code in PR #36647:
URL: https://github.com/apache/arrow/pull/36647#discussion_r1262222996


##########
cpp/src/parquet/level_conversion_inc.h:
##########
@@ -30,8 +30,7 @@
 #include "parquet/exception.h"
 #include "parquet/level_comparison.h"
 
-namespace parquet {
-namespace internal {
+namespace parquet::internal {
 #ifndef PARQUET_IMPL_NAMESPACE
 #error "PARQUET_IMPL_NAMESPACE must be defined"
 #endif

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] mapleFU commented on pull request #36647: GH-36643: [C++][Parquet] Use nested namespace in parquet

Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #36647:
URL: https://github.com/apache/arrow/pull/36647#issuecomment-1633649677

   ```
   error    libmamba Failed to download package from https://conda.anaconda.org/conda-forge/nomkl-1.0-h5ca1d4c_0.tar.bz2 (status 404)
   Multi-download failed. Reason: Transfer finalized, status: 404 [https://conda.anaconda.org/conda-forge/nomkl-1.0-h5ca1d4c_0.tar.bz2] 568 bytes
   ```
   
   Seems this doesn't caused by my patch https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/47536246 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org