You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/03/17 12:07:30 UTC

[GitHub] [incubator-opendal] tisonkun opened a new pull request, #1666: chore: Update metadata

tisonkun opened a new pull request, #1666:
URL: https://github.com/apache/incubator-opendal/pull/1666

   1. Drop "Databend Authors" metadata;
   2. Organize metadata in hierarchy.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #1666: chore: Update metadata

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #1666:
URL: https://github.com/apache/incubator-opendal/pull/1666#discussion_r1140153589


##########
bindings/c/Cargo.toml:
##########
@@ -16,10 +16,17 @@
 # under the License.
 
 [package]
-edition = "2021"
 name = "opendal-c"
 version = "0.1.0"

Review Comment:
   All crates, except for `opendal-c`, will have the same version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #1666: chore: Update metadata

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #1666:
URL: https://github.com/apache/incubator-opendal/pull/1666#discussion_r1140155982


##########
Cargo.toml:
##########
@@ -16,19 +16,27 @@
 # under the License.
 
 [package]
-authors = ["Apache Software Foundation <de...@opendal.apache.org>"]
-categories = ["filesystem"]
-description = "OpenDAL: Access data freely, painlessly, and efficiently."
+name = "opendal"
+version = "0.30.3"
 edition = "2021"
-exclude = [".github/", "bindings/", "profiles/", "oli/", "tests/"]
+rust-version = "1.60" # MSRV for this project - please update while bump versions
+
+exclude = [

Review Comment:
   Nice idea, I will start a new PR for that.



##########
Cargo.toml:
##########
@@ -16,19 +16,27 @@
 # under the License.
 
 [package]
-authors = ["Apache Software Foundation <de...@opendal.apache.org>"]
-categories = ["filesystem"]
-description = "OpenDAL: Access data freely, painlessly, and efficiently."
-edition = "2021"
-exclude = [".github/", "bindings/", "profiles/", "oli/", "tests/"]
-homepage = "https://opendal.apache.org/"
-keywords = ["storage", "fs", "s3", "azblob", "gcs"]
-license = "Apache-2.0"
 name = "opendal"
-repository = "https://github.com/apache/incubator-opendal"
 version = "0.30.3"
-# MSRV of OpenDAL. Please update this field while bump.
-rust-version = "1.60"
+

Review Comment:
   I prefer to keep all `toml` file sorted by `taplo` instead of organized by hand.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] tisonkun commented on pull request #1666: chore: Update metadata

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #1666:
URL: https://github.com/apache/incubator-opendal/pull/1666#issuecomment-1473759054

   > The MSRV check failed because version 1.60 does not yet support hierarchical workspace. We plan to upgrade it to version 1.64 in the next minor release.
   
   Fair enough. I'll revert the related changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] tisonkun commented on a diff in pull request #1666: chore: Update metadata

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #1666:
URL: https://github.com/apache/incubator-opendal/pull/1666#discussion_r1140157376


##########
Cargo.toml:
##########
@@ -16,19 +16,27 @@
 # under the License.
 
 [package]
-authors = ["Apache Software Foundation <de...@opendal.apache.org>"]
-categories = ["filesystem"]
-description = "OpenDAL: Access data freely, painlessly, and efficiently."
-edition = "2021"
-exclude = [".github/", "bindings/", "profiles/", "oli/", "tests/"]
-homepage = "https://opendal.apache.org/"
-keywords = ["storage", "fs", "s3", "azblob", "gcs"]
-license = "Apache-2.0"
 name = "opendal"
-repository = "https://github.com/apache/incubator-opendal"
 version = "0.30.3"
-# MSRV of OpenDAL. Please update this field while bump.
-rust-version = "1.60"
+

Review Comment:
   OK



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on pull request #1666: chore: Update metadata

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #1666:
URL: https://github.com/apache/incubator-opendal/pull/1666#issuecomment-1473756082

   The MSRV check failed because version 1.60 does not yet support hierarchical workspace. We plan to upgrade it to version 1.64 in the next minor release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #1666: chore: Update metadata

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #1666:
URL: https://github.com/apache/incubator-opendal/pull/1666#discussion_r1140161545


##########
Cargo.toml:
##########
@@ -16,19 +16,27 @@
 # under the License.
 
 [package]
-authors = ["Apache Software Foundation <de...@opendal.apache.org>"]
-categories = ["filesystem"]
-description = "OpenDAL: Access data freely, painlessly, and efficiently."
+name = "opendal"
+version = "0.30.3"
 edition = "2021"
-exclude = [".github/", "bindings/", "profiles/", "oli/", "tests/"]
+rust-version = "1.60" # MSRV for this project - please update while bump versions
+
+exclude = [

Review Comment:
   Tracked at https://github.com/apache/incubator-opendal/issues/1667



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] tisonkun commented on a diff in pull request #1666: chore: Update metadata

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #1666:
URL: https://github.com/apache/incubator-opendal/pull/1666#discussion_r1140181180


##########
Cargo.toml:
##########
@@ -16,19 +16,18 @@
 # under the License.
 
 [package]
-authors = ["Apache Software Foundation <de...@opendal.apache.org>"]
+authors = ["OpenDAL Contributors <de...@opendal.apache.org>"]

Review Comment:
   We don't use ASF because an incubating project is not fully endorsed by the ASF and I'd suggest we identify our name. "Apache OpenDAL (Incubating) Contributors" is wordy. Maybe we can add "Apache" after graduated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] tisonkun commented on a diff in pull request #1666: chore: Update metadata

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #1666:
URL: https://github.com/apache/incubator-opendal/pull/1666#discussion_r1140151954


##########
bindings/c/Cargo.toml:
##########
@@ -16,10 +16,17 @@
 # under the License.
 
 [package]
-edition = "2021"
 name = "opendal-c"
 version = "0.1.0"

Review Comment:
   May or may not we do a simultaneous release. Currently, I leave all `version`s defined in the crate instead of inheriting from the root.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] tisonkun commented on a diff in pull request #1666: chore: Update metadata

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #1666:
URL: https://github.com/apache/incubator-opendal/pull/1666#discussion_r1140150557


##########
Cargo.toml:
##########
@@ -16,19 +16,27 @@
 # under the License.
 
 [package]
-authors = ["Apache Software Foundation <de...@opendal.apache.org>"]
-categories = ["filesystem"]
-description = "OpenDAL: Access data freely, painlessly, and efficiently."
+name = "opendal"
+version = "0.30.3"
 edition = "2021"
-exclude = [".github/", "bindings/", "profiles/", "oli/", "tests/"]
+rust-version = "1.60" # MSRV for this project - please update while bump versions
+
+exclude = [

Review Comment:
   We're now having the website source code also. I'd suggest we use include, or move the opendal core crate one level down (inner) as a follow-up.



##########
Cargo.toml:
##########
@@ -16,19 +16,27 @@
 # under the License.
 
 [package]
-authors = ["Apache Software Foundation <de...@opendal.apache.org>"]
-categories = ["filesystem"]
-description = "OpenDAL: Access data freely, painlessly, and efficiently."
+name = "opendal"
+version = "0.30.3"
 edition = "2021"
-exclude = [".github/", "bindings/", "profiles/", "oli/", "tests/"]
+rust-version = "1.60" # MSRV for this project - please update while bump versions
+
+exclude = [

Review Comment:
   We're now having the website source code also. I'd suggest we use `include`, or move the opendal core crate one level down (inner) as a follow-up.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo merged pull request #1666: chore: Update metadata

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #1666:
URL: https://github.com/apache/incubator-opendal/pull/1666


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] tisonkun commented on a diff in pull request #1666: chore: Update metadata

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #1666:
URL: https://github.com/apache/incubator-opendal/pull/1666#discussion_r1140178990


##########
Cargo.toml:
##########
@@ -16,19 +16,27 @@
 # under the License.
 
 [package]
-authors = ["Apache Software Foundation <de...@opendal.apache.org>"]
-categories = ["filesystem"]
-description = "OpenDAL: Access data freely, painlessly, and efficiently."
-edition = "2021"
-exclude = [".github/", "bindings/", "profiles/", "oli/", "tests/"]
-homepage = "https://opendal.apache.org/"
-keywords = ["storage", "fs", "s3", "azblob", "gcs"]
-license = "Apache-2.0"
 name = "opendal"
-repository = "https://github.com/apache/incubator-opendal"
 version = "0.30.3"
-# MSRV of OpenDAL. Please update this field while bump.
-rust-version = "1.60"
+

Review Comment:
   Done. Although, when we use `workspace.package`, we may manually do grouping.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org