You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Norbert Luksa (Code Review)" <ge...@cloudera.org> on 2020/06/02 09:24:21 UTC
[Impala-ASF-CR] IMPALA-8755: Unlock Z-ordering by default
Norbert Luksa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16003
Change subject: IMPALA-8755: Unlock Z-ordering by default
......................................................................
IMPALA-8755: Unlock Z-ordering by default
Z-ordering has been around for a while behind a feature flag
(unlock_zorder_sort). It's around time to turn this flag on by default.
This commit beside setting the flag to true, merges the Z-order tests
from custom cluster tests into the normal test files.
Tests:
- Run all related tests.
Change-Id: I653e0e2db8f7bc2dd077943b3acf667514d45811
---
M be/src/common/global-flags.cc
M fe/src/main/cup/sql-parser.cup
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java
M fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
D testdata/workloads/functional-query/queries/QueryTest/alter-table-zorder.test
M testdata/workloads/functional-query/queries/QueryTest/alter-table.test
D testdata/workloads/functional-query/queries/QueryTest/create-table-as-select-zorder.test
M testdata/workloads/functional-query/queries/QueryTest/create-table-as-select.test
D testdata/workloads/functional-query/queries/QueryTest/create-table-like-file-zorder.test
M testdata/workloads/functional-query/queries/QueryTest/create-table-like-file.test
D testdata/workloads/functional-query/queries/QueryTest/create-table-like-table-zorder.test
M testdata/workloads/functional-query/queries/QueryTest/create-table-like-table.test
D testdata/workloads/functional-query/queries/QueryTest/create-table-zorder.test
M testdata/workloads/functional-query/queries/QueryTest/create-table.test
D tests/custom_cluster/test_zorder.py
20 files changed, 315 insertions(+), 465 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/16003/2
--
To view, visit http://gerrit.cloudera.org:8080/16003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I653e0e2db8f7bc2dd077943b3acf667514d45811
Gerrit-Change-Number: 16003
Gerrit-PatchSet: 2
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
[Impala-ASF-CR] IMPALA-8755: Unlock Z-ordering by default
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16003 )
Change subject: IMPALA-8755: Unlock Z-ordering by default
......................................................................
Patch Set 2:
I'm going to start the merge, since it'd be great to have this in. We can follow up if we want to move the flag to the graveyard
--
To view, visit http://gerrit.cloudera.org:8080/16003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I653e0e2db8f7bc2dd077943b3acf667514d45811
Gerrit-Change-Number: 16003
Gerrit-PatchSet: 2
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jun 2020 22:44:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8755: Unlock Z-ordering by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16003 )
Change subject: IMPALA-8755: Unlock Z-ordering by default
......................................................................
IMPALA-8755: Unlock Z-ordering by default
Z-ordering has been around for a while behind a feature flag
(unlock_zorder_sort). It's around time to turn this flag on by default.
This commit beside setting the flag to true, merges the Z-order tests
from custom cluster tests into the normal test files.
Tests:
- Run all related tests.
Change-Id: I653e0e2db8f7bc2dd077943b3acf667514d45811
Reviewed-on: http://gerrit.cloudera.org:8080/16003
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/common/global-flags.cc
M fe/src/main/cup/sql-parser.cup
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java
M fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
D testdata/workloads/functional-query/queries/QueryTest/alter-table-zorder.test
M testdata/workloads/functional-query/queries/QueryTest/alter-table.test
D testdata/workloads/functional-query/queries/QueryTest/create-table-as-select-zorder.test
M testdata/workloads/functional-query/queries/QueryTest/create-table-as-select.test
D testdata/workloads/functional-query/queries/QueryTest/create-table-like-file-zorder.test
M testdata/workloads/functional-query/queries/QueryTest/create-table-like-file.test
D testdata/workloads/functional-query/queries/QueryTest/create-table-like-table-zorder.test
M testdata/workloads/functional-query/queries/QueryTest/create-table-like-table.test
D testdata/workloads/functional-query/queries/QueryTest/create-table-zorder.test
M testdata/workloads/functional-query/queries/QueryTest/create-table.test
D tests/custom_cluster/test_zorder.py
20 files changed, 315 insertions(+), 465 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I653e0e2db8f7bc2dd077943b3acf667514d45811
Gerrit-Change-Number: 16003
Gerrit-PatchSet: 4
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8755: Unlock Z-ordering by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16003 )
Change subject: IMPALA-8755: Unlock Z-ordering by default
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6040/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I653e0e2db8f7bc2dd077943b3acf667514d45811
Gerrit-Change-Number: 16003
Gerrit-PatchSet: 3
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jun 2020 22:44:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8755: Unlock Z-ordering by default
Posted by "Norbert Luksa (Code Review)" <ge...@cloudera.org>.
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/16003 )
Change subject: IMPALA-8755: Unlock Z-ordering by default
......................................................................
Patch Set 4:
Sorry, didn't notice your comment, Zoltán. Will move the flag to the graveyard in a separate commit.
--
To view, visit http://gerrit.cloudera.org:8080/16003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I653e0e2db8f7bc2dd077943b3acf667514d45811
Gerrit-Change-Number: 16003
Gerrit-PatchSet: 4
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jun 2020 07:44:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8755: Unlock Z-ordering by default
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16003 )
Change subject: IMPALA-8755: Unlock Z-ordering by default
......................................................................
Patch Set 4:
No worries, it wasn't too important. It's good that this patch has been merged.
--
To view, visit http://gerrit.cloudera.org:8080/16003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I653e0e2db8f7bc2dd077943b3acf667514d45811
Gerrit-Change-Number: 16003
Gerrit-PatchSet: 4
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jun 2020 08:57:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8755: Unlock Z-ordering by default
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16003 )
Change subject: IMPALA-8755: Unlock Z-ordering by default
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16003/2/be/src/common/global-flags.cc
File be/src/common/global-flags.cc:
http://gerrit.cloudera.org:8080/#/c/16003/2/be/src/common/global-flags.cc@302
PS2, Line 302: DEFINE_bool(unlock_zorder_sort, true,
: "If true, enables using ZORDER option for SORT BY.");
Should we remove this flag and put to the graveyard? If someone doesn't want Z-order, they just won't use the SORT BY clause with ZORDER.
--
To view, visit http://gerrit.cloudera.org:8080/16003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I653e0e2db8f7bc2dd077943b3acf667514d45811
Gerrit-Change-Number: 16003
Gerrit-PatchSet: 2
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jun 2020 14:38:44 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8755: Unlock Z-ordering by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16003 )
Change subject: IMPALA-8755: Unlock Z-ordering by default
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I653e0e2db8f7bc2dd077943b3acf667514d45811
Gerrit-Change-Number: 16003
Gerrit-PatchSet: 3
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jun 2020 22:44:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8755: Unlock Z-ordering by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16003 )
Change subject: IMPALA-8755: Unlock Z-ordering by default
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I653e0e2db8f7bc2dd077943b3acf667514d45811
Gerrit-Change-Number: 16003
Gerrit-PatchSet: 3
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jun 2020 03:47:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8755: Unlock Z-ordering by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16003 )
Change subject: IMPALA-8755: Unlock Z-ordering by default
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6191/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I653e0e2db8f7bc2dd077943b3acf667514d45811
Gerrit-Change-Number: 16003
Gerrit-PatchSet: 2
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jun 2020 09:45:35 +0000
Gerrit-HasComments: No