[GitHub] [iceberg] szehon-ho commented on a diff in pull request #6836: Parquet: Optimize dictionary filter evaluation on notIn and notEq

["szehon-ho (via GitHub)" <gi...@apache.org>]

szehon-ho commented on code in PR #6836:
URL: https://github.com/apache/iceberg/pull/6836#discussion_r1107513022


##########
parquet/src/test/java/org/apache/iceberg/parquet/TestDictionaryRowGroupFilter.java:
##########
@@ -1030,7 +1030,7 @@ public void testMissingDictionaryPageForColumn() {
         IllegalStateException.class,
         "Failed to read required dictionary page for id: 5",
         () ->
-            new ParquetDictionaryRowGroupFilter(SCHEMA, notEqual("some_nulls", "some"))
+            new ParquetDictionaryRowGroupFilter(SCHEMA, equal("some_nulls", "some"))

Review Comment:
   I'm not sure it's expected behavior then.  Looks like original expectation to fail if there is no dictionary value, regardless of whether there are nulls or not?  I'm not familiar, maybe worth to check with original author @rdblue 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org