You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/03/10 19:49:13 UTC

[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links 

John Russell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6345

Change subject: IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links
......................................................................

IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links

Get rid of cloudera.com URLs within the topics/*.xml source files.

Abstract any that need to remain (e.g. blog posts) into impala_keydefs
file for easy examining and editing.

After this change, the number of source/artifact references to CDH and
Cloudera is small enough that we can enumerate exceptions and start the endgame:

Cleanup items remaining in XML source files:
grep -EiI "[^a-zA-Z]cm[^a-zA-Z]|cdh|cloudera" *.xml |
  grep -v issues.cloudera.org | wc -l
282
Cleanup items remaining in HTML output files:
grep -EiI "[^a-zA-Z]cm[^a-zA-Z]|cdh|cloudera" ../build/html/topics/*.html |
  grep -v issues.cloudera.org | wc -l
148

(These numbers will go down further when the 'installing' and 'updating'
edits land in master.)

Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_allow_unsupported_formats.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_complex_types.xml
M docs/topics/impala_create_table.xml
M docs/topics/impala_delegation.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_grant.xml
M docs/topics/impala_hbase.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_jdbc.xml
M docs/topics/impala_kerberos.xml
M docs/topics/impala_known_issues.xml
M docs/topics/impala_logging.xml
M docs/topics/impala_mem_limit.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_odbc.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_perf_cookbook.xml
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_prereqs.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_relnotes.xml
M docs/topics/impala_revoke.xml
M docs/topics/impala_security_metastore.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_udf.xml
M docs/topics/impala_views.xml
30 files changed, 75 insertions(+), 274 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/6345/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links

Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links
......................................................................


Patch Set 1:

(23 comments)

Most of the issues were caused with inconsistencies in the referenced to the keydef ditamap or missing keydef/keyref references. Needs another patch set to +1.

http://gerrit.cloudera.org:8080/#/c/6345/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

PS1, Line 319: <xref keyref="sg_hive_sql.xml"/>
Shouldn't this be "sg_hive_sql"? Here's an excerpt from the impala_keydefs_ditamap:

<keydef href="" scope="external" format="html" keys="sg_hive_sql">
    <topicmeta><linktext>the documentation for Apache Sentry</linktext></topicmeta>
  </keydef>


PS1, Line 3110: If your cluster is running an older release that has this restriction,
              :         to use both of these security features with Impala through a JDBC application,
              :         use the Cloudera JDBC Connector as the JDBC driver.
This is confusing. Try chunking this up into two sentences. For example: "If your cluster is running an older release that has this restriction, use Kerberos and SSL with Impala through a JDBC application. Then use the appropriate JDBC Connector as the JDBC driver." This makes it more "grokable" and removes the proprietary reference.


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:

PS1, Line 1293: <row>
              : <entry>CREATE EXTERNAL TABLE</entry>
              : <entry>ALL, SELECT</entry>
              : <entry>Database (ALL), URI (SELECT)</entry>
              : </row>
              : <row>
              : <entry>SELECT</entry>
              : <entry>SELECT</entry>
              : <entry rev="2.3.0 collevelauth">Table, View; you can have SELECT privilege for a view without having SELECT privilege
              : for the underlying tables. See
              : <xref keyref="sg_hive_sql"/>
              : for details about column-level authorization.
              : Before column-level authorization was added in <keyword keyref="impala23_full"/> the way to implement
              : column-level security was by creating views that referenced particular sets of columns.</entry>
              : </row>
              : <row>
              : <entry>USE</entry>
              : <entry>Any privilege</entry>
              : <entry>Any object in the database</entry>
              : </row>
              : <row rev="1.2">
Could this verbiage be deleted since it is commented out? It would reduce clutter and complexity.


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_fixed_issues.xml
File docs/topics/impala_fixed_issues.xml:

PS1, Line 1346: <title>Issues Fixed in <keyword keyref="impala228"/></title>
The "Impala 2.2.8" was dropped from the heading in the rendered docs (both html & pdf). When I looked in the impala_keydefs.ditamap, I see that it's missing from there. You must define "impala228" there.


PS1, Line 1460: <title>Issues Fixed in <keyword keyref="impala227"/></title>
Same thing happened to this heading--the reference to "Impala 2.2.7" was dropped in the rendered doc (both html & pdf). Same as previous keyref, there is no definition for "impala227" in impala_keydefs.ditamap.


PS1, Line 1886: <title>Issues Fixed in <keyword keyref="impala221"/></title>
"impala221" isn't defined in impala_keydefs.ditamap so it isn't showing up in the heading of rendered docs. (html & pdf)


PS1, Line 2088: <title>Issues Fixed in <keyword keyref="impala2310"/></title>
"impala2310" not defined in keydefs ditamap so dropped from rendered docs.


PS1, Line 2098: <title>Issues Fixed in <keyword keyref="impala217"/></title>
"impala217" not defined in keydefs ditamap so dropped from rendered docs.


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_incompatible_changes.xml
File docs/topics/impala_incompatible_changes.xml:

PS1, Line 816: /
Trailing forward slash should be removed from heading. Shows up in rendered doc (both html & pdf)


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_new_features.xml
File docs/topics/impala_new_features.xml:

PS1, Line 2153: impala_authorization.xml#authorization
This value is not present in the keydefs ditamap, so it was dropped out the of rendered docs completely (both html & pdf). Sentence in rendered docs is, "See for details."


PS1, Line 2373: impala_authorization.xml#authorization
Same thing happened here. This value is not present in the keydefs ditamap so reference was completely dropped in the rendered doc (both html & pdf). Sentence in rendered doc reads, "See for details."


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_odbc.xml
File docs/topics/impala_odbc.xml:

PS1, Line 62: xref keyref="3mDesWddUS">
The URL that this points to in the keydefs ditamap 404's.


PS1, Line 101: Cloudera-ODBC-Driver-for-Impala-Install-Guide.pdf
Could this proprietary reference be removed?


PS1, Line 104: ClouderaImpalaODBC.dmg
Could this proprietary reference be removed?


PS1, Line 112: Cloudera ODBC Driver for Impala Install Guide.pdf
Could this proprietary reference be removed?


PS1, Line 129: Sample Cloudera Impala DSN=Cloudera ODBC Driver for Impala
Could this proprietary reference be removed?


PS1, Line 131: Sample Cloudera Impala DSN
Could this proprietary reference be removed?


PS1, Line 138: cloudera/impalaodbc/lib/universal/libcloudera
Could these proprietary references be removed?


PS1, Line 170: cloudera
Could this proprietary reference be removed?


PS1, Line 182: cloudera
Could this proprietary reference be removed?


PS1, Line 209: conref="../shared/impala_common.xml#common/jdbc_odbc_complex_types
This conref'd content contains a proprietary reference to "Cloudera."


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_perf_stats.xml
File docs/topics/impala_perf_stats.xml:

PS1, Line 129: <ph rev="upstream">Cloudera</ph> recommends
"Cloudera recommends" reference.


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_udf.xml
File docs/topics/impala_udf.xml:

PS1, Line 419: xref keyref="archive_root
You need to provide link text, else the URL (containing proprietary reference) displays in the rendered doc (html & pdf).


-- 
To view, visit http://gerrit.cloudera.org:8080/6345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links
......................................................................


Patch Set 2:

(23 comments)

Doing these on Saturday because Sunday is Red Hot Chili Peppers concert.

http://gerrit.cloudera.org:8080/#/c/6345/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

PS1, Line 319: <xref keyref="sg_hive_sql"/>
> Shouldn't this be "sg_hive_sql"? Here's an excerpt from the impala_keydefs_
Done


PS1, Line 3110: If your cluster is running an older release that has this restriction,
              :         use an alternative JDBC driver that supports
              :         both of these security features.
> This is confusing. Try chunking this up into two sentences. For example: "I
I'll flip around the parts of the sentence a bit more.


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:

PS1, Line 1293: 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
> Could this verbiage be deleted since it is commented out? It would reduce c
Done


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_fixed_issues.xml
File docs/topics/impala_fixed_issues.xml:

PS1, Line 1346: <title>Issues Fixed in <keyword keyref="impala228"/></title>
> The "Impala 2.2.8" was dropped from the heading in the rendered docs (both 
Done. Very strange that the mismatch didn't produce any build errors!


PS1, Line 1460: <title>Issues Fixed in <keyword keyref="impala227"/></title>
> Same thing happened to this heading--the reference to "Impala 2.2.7" was dr
Done


PS1, Line 1886: <title>Issues Fixed in <keyword keyref="impala221"/></title>
> "impala221" isn't defined in impala_keydefs.ditamap so it isn't showing up 
Done


PS1, Line 2088: <title>Issues Fixed in <keyword keyref="impala2310"/></title>
> "impala2310" not defined in keydefs ditamap so dropped from rendered docs.
Done


PS1, Line 2098: <title>Issues Fixed in <keyword keyref="impala217"/></title>
> "impala217" not defined in keydefs ditamap so dropped from rendered docs.
Done


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_incompatible_changes.xml
File docs/topics/impala_incompatible_changes.xml:

PS1, Line 816: /
> Trailing forward slash should be removed from heading. Shows up in rendered
Done


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_new_features.xml
File docs/topics/impala_new_features.xml:

PS1, Line 2153: ty-related SQL statements work along w
> This value is not present in the keydefs ditamap, so it was dropped out the
Done


PS1, Line 2373: >GRANT</codeph> and <codeph>REVOKE</co
> Same thing happened here. This value is not present in the keydefs ditamap 
Done


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_odbc.xml
File docs/topics/impala_odbc.xml:

PS1, Line 62: xref keyref="odbc_driver_
> The URL that this points to in the keydefs ditamap 404's.
Done


PS1, Line 101: Cloudera-ODBC-Driver-for-Impala-Install-Guide.pdf
> Could this proprietary reference be removed?
That's a weird case because that's what comes with the driver. Let's leave these references alone for now and check with Greg.


PS1, Line 104: ClouderaImpalaODBC.dmg
> Could this proprietary reference be removed?
Ditto, leaving alone for the moment.


PS1, Line 112: Cloudera ODBC Driver for Impala Install Guide.pdf
> Could this proprietary reference be removed?
Ditto.


PS1, Line 129: Sample Cloudera Impala DSN=Cloudera ODBC Driver for Impala
> Could this proprietary reference be removed?
Ditto.


PS1, Line 131: Sample Cloudera Impala DSN
> Could this proprietary reference be removed?
Ditto.


PS1, Line 138: cloudera/impalaodbc/lib/universal/libcloudera
> Could these proprietary references be removed?
Ditto.


PS1, Line 170: cloudera
> Could this proprietary reference be removed?
Ditto.


PS1, Line 182: cloudera
> Could this proprietary reference be removed?
Ditto.


PS1, Line 209: conref="../shared/impala_common.xml#common/jdbc_odbc_complex_types
> This conref'd content contains a proprietary reference to "Cloudera."
I'll take the word "Cloudera" out of the references to the names, but that might be a bad idea as those are the official names.


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_perf_stats.xml
File docs/topics/impala_perf_stats.xml:

PS1, Line 129: Where practical,
> "Cloudera recommends" reference.
Done


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_udf.xml
File docs/topics/impala_udf.xml:

PS1, Line 419: xref keyref="archive_root
> You need to provide link text, else the URL (containing proprietary referen
Done. Suppressing the visible 'cloudera' doesn't help with the grep counting method though, because it's still present in the HTML <a href=...> tag.


-- 
To view, visit http://gerrit.cloudera.org:8080/6345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links
......................................................................


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links
......................................................................


Patch Set 3:

Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/79/

-- 
To view, visit http://gerrit.cloudera.org:8080/6345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links

Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links
......................................................................


Patch Set 3: Code-Review+1

LGTM.

-- 
To view, visit http://gerrit.cloudera.org:8080/6345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links
......................................................................


Patch Set 3: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/6345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links
......................................................................


Patch Set 4: Code-Review+2

Fixed another merge conflict.

-- 
To view, visit http://gerrit.cloudera.org:8080/6345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links
......................................................................


Patch Set 4:

Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/82/

-- 
To view, visit http://gerrit.cloudera.org:8080/6345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).

Change subject: IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links
......................................................................

IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links

Get rid of cloudera.com URLs within the topics/*.xml source files.

Abstract any that need to remain (e.g. blog posts) into impala_keydefs
file for easy examining and editing.

After this change, the number of source/artifact references to CDH and
Cloudera is small enough that we can enumerate exceptions and start the endgame:

Cleanup items remaining in XML source files:
grep -EiI "[^a-zA-Z]cm[^a-zA-Z]|cdh|cloudera" *.xml |
  grep -v issues.cloudera.org | wc -l
282
Cleanup items remaining in HTML output files:
grep -EiI "[^a-zA-Z]cm[^a-zA-Z]|cdh|cloudera" ../build/html/topics/*.html |
  grep -v issues.cloudera.org | wc -l
148

(These numbers will go down further when the 'installing' and 'updating'
edits land in master.)

Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_allow_unsupported_formats.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_complex_types.xml
M docs/topics/impala_create_table.xml
M docs/topics/impala_delegation.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_grant.xml
M docs/topics/impala_hbase.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_jdbc.xml
M docs/topics/impala_kerberos.xml
M docs/topics/impala_known_issues.xml
M docs/topics/impala_logging.xml
M docs/topics/impala_mem_limit.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_odbc.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_perf_cookbook.xml
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_prereqs.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_relnotes.xml
M docs/topics/impala_revoke.xml
M docs/topics/impala_security_metastore.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_udf.xml
M docs/topics/impala_views.xml
30 files changed, 91 insertions(+), 633 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/6345/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>

[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links
......................................................................


Patch Set 4: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/6345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links

Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6345/2/docs/impala_keydefs.ditamap
File docs/impala_keydefs.ditamap:

PS2, Line 10345: 2209
why was this modified?


-- 
To view, visit http://gerrit.cloudera.org:8080/6345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#3).

Change subject: IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links
......................................................................

IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links

Get rid of cloudera.com URLs within the topics/*.xml source files.

Abstract any that need to remain (e.g. blog posts) into impala_keydefs
file for easy examining and editing.

After this change, the number of source/artifact references to CDH and
Cloudera is small enough that we can enumerate exceptions and start the endgame:

Cleanup items remaining in XML source files:
grep -EiI "[^a-zA-Z]cm[^a-zA-Z]|cdh|cloudera" *.xml |
  grep -v issues.cloudera.org | wc -l
282
Cleanup items remaining in HTML output files:
grep -EiI "[^a-zA-Z]cm[^a-zA-Z]|cdh|cloudera" ../build/html/topics/*.html |
  grep -v issues.cloudera.org | wc -l
148

(These numbers will go down further when the 'installing' and 'updating'
edits land in master.)

Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_allow_unsupported_formats.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_complex_types.xml
M docs/topics/impala_create_table.xml
M docs/topics/impala_delegation.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_grant.xml
M docs/topics/impala_hbase.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_jdbc.xml
M docs/topics/impala_kerberos.xml
M docs/topics/impala_known_issues.xml
M docs/topics/impala_logging.xml
M docs/topics/impala_mem_limit.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_odbc.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_perf_cookbook.xml
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_prereqs.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_relnotes.xml
M docs/topics/impala_revoke.xml
M docs/topics/impala_security_metastore.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_udf.xml
M docs/topics/impala_views.xml
30 files changed, 90 insertions(+), 632 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/6345/3
-- 
To view, visit http://gerrit.cloudera.org:8080/6345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>

[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, Ambreen Kazi,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6345

to look at the new patch set (#4).

Change subject: IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links
......................................................................

IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links

Get rid of cloudera.com URLs within the topics/*.xml source files.

Abstract any that need to remain (e.g. blog posts) into impala_keydefs
file for easy examining and editing.

After this change, the number of source/artifact references to CDH and
Cloudera is small enough that we can enumerate exceptions and start the endgame:

Cleanup items remaining in XML source files:
grep -EiI "[^a-zA-Z]cm[^a-zA-Z]|cdh|cloudera" *.xml |
  grep -v issues.cloudera.org | wc -l
282
Cleanup items remaining in HTML output files:
grep -EiI "[^a-zA-Z]cm[^a-zA-Z]|cdh|cloudera" ../build/html/topics/*.html |
  grep -v issues.cloudera.org | wc -l
148

(These numbers will go down further when the 'installing' and 'updating'
edits land in master.)

Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_allow_unsupported_formats.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_complex_types.xml
M docs/topics/impala_create_table.xml
M docs/topics/impala_delegation.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_grant.xml
M docs/topics/impala_hbase.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_jdbc.xml
M docs/topics/impala_kerberos.xml
M docs/topics/impala_known_issues.xml
M docs/topics/impala_logging.xml
M docs/topics/impala_mem_limit.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_odbc.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_perf_cookbook.xml
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_prereqs.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_relnotes.xml
M docs/topics/impala_revoke.xml
M docs/topics/impala_security_metastore.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_udf.xml
M docs/topics/impala_views.xml
30 files changed, 97 insertions(+), 632 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/6345/4
-- 
To view, visit http://gerrit.cloudera.org:8080/6345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>

[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links
......................................................................


Patch Set 3:

(1 comment)

Correct accidental change - finger fumble.

http://gerrit.cloudera.org:8080/#/c/6345/2/docs/impala_keydefs.ditamap
File docs/impala_keydefs.ditamap:

PS2, Line 10345: 2210
> why was this modified?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links
......................................................................


IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links

Get rid of cloudera.com URLs within the topics/*.xml source files.

Abstract any that need to remain (e.g. blog posts) into impala_keydefs
file for easy examining and editing.

After this change, the number of source/artifact references to CDH and
Cloudera is small enough that we can enumerate exceptions and start the endgame:

Cleanup items remaining in XML source files:
grep -EiI "[^a-zA-Z]cm[^a-zA-Z]|cdh|cloudera" *.xml |
  grep -v issues.cloudera.org | wc -l
282
Cleanup items remaining in HTML output files:
grep -EiI "[^a-zA-Z]cm[^a-zA-Z]|cdh|cloudera" ../build/html/topics/*.html |
  grep -v issues.cloudera.org | wc -l
148

(These numbers will go down further when the 'installing' and 'updating'
edits land in master.)

Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
Reviewed-on: http://gerrit.cloudera.org:8080/6345
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_allow_unsupported_formats.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_complex_types.xml
M docs/topics/impala_create_table.xml
M docs/topics/impala_delegation.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_grant.xml
M docs/topics/impala_hbase.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_jdbc.xml
M docs/topics/impala_kerberos.xml
M docs/topics/impala_known_issues.xml
M docs/topics/impala_logging.xml
M docs/topics/impala_mem_limit.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_odbc.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_perf_cookbook.xml
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_prereqs.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_relnotes.xml
M docs/topics/impala_revoke.xml
M docs/topics/impala_security_metastore.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_udf.xml
M docs/topics/impala_views.xml
30 files changed, 97 insertions(+), 632 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  John Russell: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>