You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/04/06 18:18:27 UTC
[GitHub] [helix] zhangmeng916 opened a new pull request #928: fix customized
state provider
zhangmeng916 opened a new pull request #928: fix customized state provider
URL: https://github.com/apache/helix/pull/928
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
(#888 )
### Description
This PR changes the customized state provider factory to allow customer to build the provider based on either zkaddress, cluster name, instance name or helix manager and instance name. If customer chooses to build the provider with the first option, Helix will provide a manager for it.
### Tests
- [ ] The following is the result of the "mvn test" command on the appropriate module:
(Copy & paste the result of "mvn test")
### Commits
- [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation (Optional)
- [ ] In case of new functionality, my PR adds documentation in the following wiki page:
### Code Quality
- [X] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on issue #928: fix customized state
provider
Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on issue #928: fix customized state provider
URL: https://github.com/apache/helix/pull/928#issuecomment-610536924
This PR is ready to merge, approved by @jiajunwang
Final commit message
"Modify customized state provider factory. The new factory can build a customized state provider with either Helix own manager or a customer input manager."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang merged pull request #928: fix customized state
provider
Posted by GitBox <gi...@apache.org>.
jiajunwang merged pull request #928: fix customized state provider
URL: https://github.com/apache/helix/pull/928
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org