You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/06/07 12:55:21 UTC

[GitHub] [hadoop] ZanderXu commented on pull request #4409: HDFS-16623. Avoid IllegalArgumentException in LifelineSender

ZanderXu commented on PR #4409:
URL: https://github.com/apache/hadoop/pull/4409#issuecomment-1148630372

   Thanks @cnauroth for your comment. Do you mean to add a UT to test that `getLifelineWaitTime()` can only return non-negative numbers?
   I think if we need a UT, we should test the LifelineSender thread exit, but it is difficult to judge whether the thread exits or not. Do you have some good ideas? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org