You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/12/23 23:54:14 UTC
Review Request: SQOOP-802 Sqoop2: Convert main "Manager" classes to
singletons.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8753/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
I've changed the implementation as proposed on JIRA. No new or changed functionality was introduced.
This addresses bug SQOOP-802.
https://issues.apache.org/jira/browse/SQOOP-802
Diffs
-----
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java c2342f727f58e56f9eaad26f861ece7b7cea858d
core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java 043f8e6a18a6e584be9dc4454c115724ae7dbdd5
core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java a5ac74f8fe183a387b383b95ece7424cdd983237
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java eb7ed5b7ea89da2c7a775fb4290cfd5fca4bf2ce
core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java 632bc603d7a34dc9d03f093014b826715d755cdb
core/src/test/java/org/apache/sqoop/core/TestConfiguration.java bd912eabcad844203fea07eeb77cece0988835bd
core/src/test/java/org/apache/sqoop/repository/TestRepositoryManager.java a95c2855e05c99f93a6042b3d470844291d8a253
server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java b77c5d76974cdf791ed414041a39bbd79760ceec
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 6dee70ce589f4ba18fd16047245f496ed718bc0f
server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java 45a2d42d86658510db4e17c5a913aec1e14625e9
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 6dea45f02a598558862014f4a271ddd5df8656fe
server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 6e541d501aa5ead353a6ec6e284e932669f6c60a
server/src/main/java/org/apache/sqoop/server/ServerInitializer.java 256262bb01b1e1ceb64f1ed598cc77302866319e
Diff: https://reviews.apache.org/r/8753/diff/
Testing
-------
Unit tests are passing and I've tested this on real cluster.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-802 Sqoop2: Convert main "Manager" classes to
singletons.
Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8753/#review14924
-----------------------------------------------------------
Ship it!
Ship It!
- Bilung Lee
On Dec. 23, 2012, 10:54 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8753/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2012, 10:54 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've changed the implementation as proposed on JIRA. No new or changed functionality was introduced.
>
>
> This addresses bug SQOOP-802.
> https://issues.apache.org/jira/browse/SQOOP-802
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java c2342f727f58e56f9eaad26f861ece7b7cea858d
> core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java 043f8e6a18a6e584be9dc4454c115724ae7dbdd5
> core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java a5ac74f8fe183a387b383b95ece7424cdd983237
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java eb7ed5b7ea89da2c7a775fb4290cfd5fca4bf2ce
> core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java 632bc603d7a34dc9d03f093014b826715d755cdb
> core/src/test/java/org/apache/sqoop/core/TestConfiguration.java bd912eabcad844203fea07eeb77cece0988835bd
> core/src/test/java/org/apache/sqoop/repository/TestRepositoryManager.java a95c2855e05c99f93a6042b3d470844291d8a253
> server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java b77c5d76974cdf791ed414041a39bbd79760ceec
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 6dee70ce589f4ba18fd16047245f496ed718bc0f
> server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java 45a2d42d86658510db4e17c5a913aec1e14625e9
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 6dea45f02a598558862014f4a271ddd5df8656fe
> server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 6e541d501aa5ead353a6ec6e284e932669f6c60a
> server/src/main/java/org/apache/sqoop/server/ServerInitializer.java 256262bb01b1e1ceb64f1ed598cc77302866319e
>
> Diff: https://reviews.apache.org/r/8753/diff/
>
>
> Testing
> -------
>
> Unit tests are passing and I've tested this on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>