You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2017/09/04 21:14:00 UTC

[jira] [Resolved] (WICKET-6459) Ajax re-renders of enclosures do not render their children's header contributions

     [ https://issues.apache.org/jira/browse/WICKET-6459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-6459.
-------------------------------------
       Resolution: Fixed
         Assignee: Martin Grigorov
    Fix Version/s: 8.0.0-M8
                   7.9.0

The PR is merged!

I didn't notice earlier that the commit messages do not mention WICKET-6459 and that's why they do not appear in this ticket.

Thank you, [~dpoliakas]!

> Ajax re-renders of enclosures do not render their children's header contributions
> ---------------------------------------------------------------------------------
>
>                 Key: WICKET-6459
>                 URL: https://issues.apache.org/jira/browse/WICKET-6459
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 8.0.0-M6, 7.8.0
>            Reporter: Domas Poliakas
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: 7.9.0, 8.0.0-M8
>
>
> When a component in an enclosure is added to the AjaxRequestTarget, its (and subsequently its children's) header contributions are not rendered. 
> AjaxEnclosureListener replaces any components with enclosures that are in the target with their enclosures. However, in the wicket hierarchy the enclosures appear to be siblings to the components they enclose. What this causes is that when the default ChildFirstHeaderRenderStrategy attempts to render the header contributions for the enclosure, nothing is rendered as the enclosure itself has no children in the hierarchy.
> On one hand, ChildFirstHeaderRenderStrategy seems to be the culprit - it should detect enclosures and act accordingly - but fixing the problem there would cause it to resurface in the future if the default implementation of header render strategy is changed. What would be a correct way fix for this? 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)