You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/17 19:18:46 UTC

[GitHub] [arrow] Dandandan commented on a change in pull request #9234: ARROW-11290: [Rust][DataFusion] Address hash aggregate performance issue with high number of groups

Dandandan commented on a change in pull request #9234:
URL: https://github.com/apache/arrow/pull/9234#discussion_r559225738



##########
File path: rust/datafusion/src/physical_plan/hash_aggregate.rs
##########
@@ -288,6 +288,9 @@ fn group_aggregate_batch(
     // Make sure we can create the accumulators or otherwise return an error
     create_accumulators(aggr_expr).map_err(DataFusionError::into_arrow_external_error)?;
 
+    // Keys received in this batch
+    let mut batch_keys = vec![];

Review comment:
       That's what I thought first, but this is checked already when `push`ing the keys to the vec.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org