You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/21 19:24:31 UTC
[GitHub] [airflow] kevinsunny1996 opened a new issue, #24587: Legal short option pattern regex confirmation
kevinsunny1996 opened a new issue, #24587:
URL: https://github.com/apache/airflow/issues/24587
Hi everyone , was referring how to write tests and was checking airflow repo , for the following code snippet:
https://github.com/apache/airflow/blob/main/tests/cli/test_cli_parser.py#L36
The comment contained # Only can be `-[a-z]` or `-[A-Z]`
However the regex seems to be missing Z in the test code.
Wanted to check if my finding is correct , I can contribute to the same by fixing the regex and raise a PR for the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #24587: Legal short option pattern regex confirmation
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #24587:
URL: https://github.com/apache/airflow/issues/24587#issuecomment-1162269746
But yes - seems it needs fixing. But issues should not be used for questions. If you want to discuss something - open "Github Discussions" instead - but discussing stuff on a code are much better done with a PR - because you can discuss directly on the code - and if you submit a change, there is no doubt what you want to do (and it's as easy to close a PR as it is to close an issue or discussion).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #24587: Legal short option pattern regex confirmation
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #24587:
URL: https://github.com/apache/airflow/issues/24587#issuecomment-1162229682
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #24587: Legal short option pattern regex confirmation
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #24587:
URL: https://github.com/apache/airflow/issues/24587#issuecomment-1162264338
Just open PR with fixes and discuss it there. Opening an issue for such a question is completely unnecessary overhead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #24587: Legal short option pattern regex confirmation
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #24587: Legal short option pattern regex confirmation
URL: https://github.com/apache/airflow/issues/24587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org