You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2005/08/23 06:47:40 UTC
[Bug 4555] New: URIDNSBL aborts prematurely due to times_count_was_same
http://bugzilla.spamassassin.org/show_bug.cgi?id=4555
Summary: URIDNSBL aborts prematurely due to times_count_was_same
Product: Spamassassin
Version: 3.1.0
Platform: Macintosh
OS/Version: Mac OS X
Status: NEW
Severity: normal
Priority: P5
Component: Plugins
AssignedTo: dev@spamassassin.apache.org
ReportedBy: steve@planomartins.com
The following code:
# avoid looping forever if we haven't got all results.
if ($scanstate->{last_count} == $numkeys) {
$scanstate->{times_count_was_same}++;
if ($scanstate->{times_count_was_same} > 20) {
dbg("uridnsbl: escaping: must have lost requests");
$self->abort_remaining_lookups ($scanstate);
$stillwaiting = 0;
}
in complete_lookups can cause lookups to abort long before the specified timeout.
As this log info shows, it can loop 20 times within a second and abort. I've tested increasing the
times_count_was_same check to larger numbers (like 200) and the normal lookups complete within a
couple of seconds instead of aborting as the current code does. This check for times_count_was_same
should be rethought, or perhaps only done when the uridnsbl_timeout time has been exceeded or
something...
[860] dbg: uridnsbl: domains to query: networkforgood.org
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: query for networkforgood.org took 28 seconds to look up
(multi.surbl.org.:networkforgood.org)
[860] dbg: uridnsbl: queries completed: 1 started: 0
[860] dbg: uridnsbl: queries active: NS=1 at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: queries completed: 1 started: 5
[860] dbg: uridnsbl: queries active: at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: waiting 40 seconds for URIDNSBL lookups to complete
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: queries completed: 0 started: 0
[860] dbg: uridnsbl: queries active: A=5 at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: queries completed: 0 started: 0
[860] dbg: uridnsbl: queries active: A=5 at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: queries completed: 0 started: 0
[860] dbg: uridnsbl: queries active: A=5 at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: queries completed: 0 started: 0
[860] dbg: uridnsbl: queries active: A=5 at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: queries completed: 0 started: 0
[860] dbg: uridnsbl: queries active: A=5 at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: queries completed: 0 started: 0
[860] dbg: uridnsbl: queries active: A=5 at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: queries completed: 0 started: 0
[860] dbg: uridnsbl: queries active: A=5 at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: queries completed: 0 started: 0
[860] dbg: uridnsbl: queries active: A=5 at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: queries completed: 0 started: 0
[860] dbg: uridnsbl: queries active: A=5 at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: queries completed: 0 started: 0
[860] dbg: uridnsbl: queries active: A=5 at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: queries completed: 0 started: 0
[860] dbg: uridnsbl: queries active: A=5 at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: queries completed: 0 started: 0
[860] dbg: uridnsbl: queries active: A=5 at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: queries completed: 0 started: 0
[860] dbg: uridnsbl: queries active: A=5 at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: queries completed: 0 started: 0
[860] dbg: uridnsbl: queries active: A=5 at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: queries completed: 0 started: 0
[860] dbg: uridnsbl: queries active: A=5 at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: queries completed: 0 started: 0
[860] dbg: uridnsbl: queries active: A=5 at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: queries completed: 0 started: 0
[860] dbg: uridnsbl: queries active: A=5 at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: queries completed: 0 started: 0
[860] dbg: uridnsbl: queries active: A=5 at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: queries completed: 0 started: 0
[860] dbg: uridnsbl: queries active: A=5 at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: queries completed: 0 started: 0
[860] dbg: uridnsbl: queries active: A=5 at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: select found 1 socks ready
[860] dbg: uridnsbl: queries completed: 0 started: 0
[860] dbg: uridnsbl: queries active: A=5 at Mon Aug 22 23:19:20 2005
[860] dbg: uridnsbl: escaping: must have lost requests
[860] dbg: uridnsbl: aborting remaining lookups
[860] dbg: uridnsbl: done waiting for URIDNSBL lookups to complete
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4555] URIDNSBL aborts prematurely due to times_count_was_same
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4555
------- Additional Comments From jm@jmason.org 2005-09-07 18:24 -------
URIBL should not be looping so quickly -- there's some timeout/sleep code to
avoid that, which is obv not working so well on MacOS :(
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4555] URIDNSBL aborts prematurely due to times_count_was_same
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4555
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From felicity@apache.org 2006-12-05 12:07 -------
this code doesn't exist in 3.2, so I'm going to call this fixed.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.