You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zipkin.apache.org by GitBox <gi...@apache.org> on 2019/05/09 04:12:34 UTC

[GitHub] [incubator-zipkin] adriancole commented on issue #2573: Uses okio/moshi natively in Elasticsearch everywhere

adriancole commented on issue #2573: Uses okio/moshi natively in Elasticsearch everywhere
URL: https://github.com/apache/incubator-zipkin/pull/2573#issuecomment-490736361
 
 
   I ran a 5m load test against before and after. As it is, this doesn't make a big difference, likely because by default under load senders will produce 3MiB or so json per message. This will still result in big arrays. OTOH, we now have a chance to optimize.
   
   the left hand side is before and the right hand side is with this change. The test is brave-webmvc-example against zipkin+elasticsearch 6.7 for 5 minutes
   
   ![Screen Shot 2019-05-09 at 12 08 03 PM](https://user-images.githubusercontent.com/64215/57426825-9dfd8380-7253-11e9-9587-ae4df18d9356.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services