You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cayenne.apache.org by Andrus Adamchik <an...@objectstyle.org> on 2008/11/10 08:57:46 UTC
Removing @author tags
I'd like to suggest stripping @author tags from all Java classes. In a
mature project like Cayenne they make little sense, as many people
have touched most files over the years. They only create false
ownership perception. As my name is on most of the classes, I figured
it would be most appropriate if I suggest that myself.
Also IIRC there have been discussions in other places at Apache that
mentioned @author tags as a potential for developer legal liability
(as you know, one of the major goals of the ASF is to shield
individual contributors from such liability). I am personally less
concerned about this particular aspect, still figured I'd mention.
Thoughts?
Andrus
Re: Removing @author tags
Posted by Andrus Adamchik <an...@objectstyle.org>.
Well, we have to do both things all the time. Otherwise without tuneup
and maintenance you will invariably end up with a bad case of code rot
on any old enough project.
Andrus
On Nov 10, 2008, at 6:28 PM, Andrey Razumovsky wrote:
> No objections, though I'd spent time fixing a bug instead :-)
>
> 2008/11/10, Robert Zeigler <ro...@gmail.com>:
>>
>> +1
>>
>> Robert
>>
>> On Nov 10, 2008, at 11/107:23 AM , Tore Halset wrote:
>>
>> On Nov 10, 2008, at 8:57 , Andrus Adamchik wrote:
>>>
>>> I'd like to suggest stripping @author tags from all Java classes.
>>>>
>>>
>>> +1
>>>
>>> Regards,
>>> - Tore.
>>>
>>>
>>
Re: Removing @author tags
Posted by Andrus Adamchik <an...@objectstyle.org>.
Nice, thanks.
Andrus
On Nov 11, 2008, at 6:32 PM, Andrey Razumovsky wrote:
> Next step in cleaning Cayenne code can be removal of using of
> deprecated
> methods, unused imports etc. I'm currently looking at modeler code,
> so I
> could do the work
>
> 2008/11/11, Andrus Adamchik <an...@objectstyle.org>:
>>
>> Yeah, if you have a spare minute, I'd appreciate doing that on trunk.
>>
>> Thanks,
>> Andrus
>>
>> On Nov 11, 2008, at 1:04 AM, Aristedes Maniatis wrote:
>>
>>
>>> On 11/11/2008, at 3:28 AM, Andrey Razumovsky wrote:
>>>
>>> No objections, though I'd spent time fixing a bug instead :-)
>>>>
>>>
>>> We can just run the files through sed and it will take just a few
>>> minutes...
>>>
>>> Andrus, let me know if you want a hand doing that.
>>>
>>> Ari
>>>
>>>
>>>
>>> -------------------------->
>>> ish
>>> http://www.ish.com.au
>>> Level 1, 30 Wilson Street Newtown 2042 Australia
>>> phone +61 2 9550 5001 fax +61 2 9550 4001
>>> GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A
>>>
>>>
>>>
>>>
>>
Re: deprecated - Re: Removing @author tags
Posted by Andrey Razumovsky <ra...@gmail.com>.
Nope. I meant removing JDK deprecations, which are plenty in code. I.e.
java.awt.Window.show() -> setVisible(true).
2008/11/13, Tore Halset <ha...@pvv.ntnu.no>:
>
> On 11. nov.. 2008, at 17.32, Andrey Razumovsky wrote:
>
> Next step in cleaning Cayenne code can be removal of using of deprecated
>> methods, unused imports etc.
>>
>
> What is the plan here? Do you plan to remove things that was not deprecated
> in the 1.2/2.2 as well? Is that ok since we are shifting to a new major
> number or do we plan to make the transition as easy as possible for users?
>
> I still have lots and lots of .getDataContext() and
> .createAndRegisterNewObject() in my projects. I guess I should fix them as
> soon as possible :)
>
> Regards,
> - Tore.
>
deprecated - Re: Removing @author tags
Posted by Tore Halset <ha...@pvv.ntnu.no>.
On 11. nov.. 2008, at 17.32, Andrey Razumovsky wrote:
> Next step in cleaning Cayenne code can be removal of using of
> deprecated
> methods, unused imports etc.
What is the plan here? Do you plan to remove things that was not
deprecated in the 1.2/2.2 as well? Is that ok since we are shifting to
a new major number or do we plan to make the transition as easy as
possible for users?
I still have lots and lots of .getDataContext()
and .createAndRegisterNewObject() in my projects. I guess I should fix
them as soon as possible :)
Regards,
- Tore.
Re: Removing @author tags
Posted by Andrey Razumovsky <ra...@gmail.com>.
Next step in cleaning Cayenne code can be removal of using of deprecated
methods, unused imports etc. I'm currently looking at modeler code, so I
could do the work
2008/11/11, Andrus Adamchik <an...@objectstyle.org>:
>
> Yeah, if you have a spare minute, I'd appreciate doing that on trunk.
>
> Thanks,
> Andrus
>
> On Nov 11, 2008, at 1:04 AM, Aristedes Maniatis wrote:
>
>
>> On 11/11/2008, at 3:28 AM, Andrey Razumovsky wrote:
>>
>> No objections, though I'd spent time fixing a bug instead :-)
>>>
>>
>> We can just run the files through sed and it will take just a few
>> minutes...
>>
>> Andrus, let me know if you want a hand doing that.
>>
>> Ari
>>
>>
>>
>> -------------------------->
>> ish
>> http://www.ish.com.au
>> Level 1, 30 Wilson Street Newtown 2042 Australia
>> phone +61 2 9550 5001 fax +61 2 9550 4001
>> GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A
>>
>>
>>
>>
>
Re: Removing @author tags
Posted by Andrus Adamchik <an...@objectstyle.org>.
Yeah, if you have a spare minute, I'd appreciate doing that on trunk.
Thanks,
Andrus
On Nov 11, 2008, at 1:04 AM, Aristedes Maniatis wrote:
>
> On 11/11/2008, at 3:28 AM, Andrey Razumovsky wrote:
>
>> No objections, though I'd spent time fixing a bug instead :-)
>
> We can just run the files through sed and it will take just a few
> minutes...
>
> Andrus, let me know if you want a hand doing that.
>
> Ari
>
>
>
> -------------------------->
> ish
> http://www.ish.com.au
> Level 1, 30 Wilson Street Newtown 2042 Australia
> phone +61 2 9550 5001 fax +61 2 9550 4001
> GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A
>
>
>
Re: Removing @author tags
Posted by Aristedes Maniatis <ar...@ish.com.au>.
On 11/11/2008, at 3:28 AM, Andrey Razumovsky wrote:
> No objections, though I'd spent time fixing a bug instead :-)
We can just run the files through sed and it will take just a few
minutes...
Andrus, let me know if you want a hand doing that.
Ari
-------------------------->
ish
http://www.ish.com.au
Level 1, 30 Wilson Street Newtown 2042 Australia
phone +61 2 9550 5001 fax +61 2 9550 4001
GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A
Re: Removing @author tags
Posted by Andrey Razumovsky <ra...@gmail.com>.
No objections, though I'd spent time fixing a bug instead :-)
2008/11/10, Robert Zeigler <ro...@gmail.com>:
>
> +1
>
> Robert
>
> On Nov 10, 2008, at 11/107:23 AM , Tore Halset wrote:
>
> On Nov 10, 2008, at 8:57 , Andrus Adamchik wrote:
>>
>> I'd like to suggest stripping @author tags from all Java classes.
>>>
>>
>> +1
>>
>> Regards,
>> - Tore.
>>
>>
>
Re: Removing @author tags
Posted by Robert Zeigler <ro...@gmail.com>.
+1
Robert
On Nov 10, 2008, at 11/107:23 AM , Tore Halset wrote:
> On Nov 10, 2008, at 8:57 , Andrus Adamchik wrote:
>
>> I'd like to suggest stripping @author tags from all Java classes.
>
> +1
>
> Regards,
> - Tore.
>
Re: Removing @author tags
Posted by Mike Kienenberger <mk...@gmail.com>.
+1
On Mon, Nov 10, 2008 at 8:23 AM, Tore Halset <ha...@pvv.ntnu.no> wrote:
> On Nov 10, 2008, at 8:57 , Andrus Adamchik wrote:
>
>> I'd like to suggest stripping @author tags from all Java classes.
>
> +1
>
> Regards,
> - Tore.
>
>
Re: Removing @author tags
Posted by Tore Halset <ha...@pvv.ntnu.no>.
On Nov 10, 2008, at 8:57 , Andrus Adamchik wrote:
> I'd like to suggest stripping @author tags from all Java classes.
+1
Regards,
- Tore.
Re: Removing @author tags
Posted by Kevin Menard <ni...@gmail.com>.
Sounds good to me. The commit history is a better indicator of who to
talk to if one does have a question to ask the author anyway.
--
Kevin
On Mon, Nov 10, 2008 at 2:57 AM, Andrus Adamchik <an...@objectstyle.org> wrote:
> I'd like to suggest stripping @author tags from all Java classes. In a
> mature project like Cayenne they make little sense, as many people have
> touched most files over the years. They only create false ownership
> perception. As my name is on most of the classes, I figured it would be most
> appropriate if I suggest that myself.
>
> Also IIRC there have been discussions in other places at Apache that
> mentioned @author tags as a potential for developer legal liability (as you
> know, one of the major goals of the ASF is to shield individual contributors
> from such liability). I am personally less concerned about this particular
> aspect, still figured I'd mention.
>
> Thoughts?
>
> Andrus
>