[GitHub] [netbeans] mbien commented on a diff in pull request #3981: Preventing to create hints more times.

[GitBox <gi...@apache.org>]

mbien commented on code in PR #3981:
URL: https://github.com/apache/netbeans/pull/3981#discussion_r909122294


##########
groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/compiler/error/GroovyError.java:
##########
@@ -117,4 +117,71 @@ public boolean isLineError() {
     public boolean showExplorerBadge() {
         return false;
     }
+
+    @Override
+    public boolean equals(Object obj) {
+        if (obj == null) {
+            return false;
+        }
+        if (obj.getClass() != GroovyError.class) {
+            return false;
+        }
+
+        final GroovyError test = (GroovyError)obj;
+
+        if (this.start != test.start) {
+            return false;
+        }
+
+        if (this.end != test.end) {
+            return false;
+        }
+        
+        if ((this.description == null && test.description != null) || 
+                (this.description != null && test.description == null)
+                || !this.description.equals(test.description)) {

Review Comment:
   @ppisl why was this merged without taking reviewer comments into account? If someone takes their time and reviews a PR it would be also good to leave at least a comment why the decision was made to merge it as is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists