You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Lars Hofhansl (JIRA)" <ji...@apache.org> on 2011/09/14 19:41:08 UTC
[jira] [Created] (HBASE-4404) ReplicationSource thread is not
always shutdown when a peer is removed.
ReplicationSource thread is not always shutdown when a peer is removed.
-----------------------------------------------------------------------
Key: HBASE-4404
URL: https://issues.apache.org/jira/browse/HBASE-4404
Project: HBase
Issue Type: Bug
Components: replication
Affects Versions: 0.90.4, 0.92.0
Reporter: Lars Hofhansl
Priority: Minor
Fix For: 0.92.0
When a replication peer is removed the ReplicationSource's thread is not shutdown if it is still trying to get a connection to the peer.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4404) ReplicationSource thread is not
always shutdown when a peer is removed.
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104827#comment-13104827 ]
Lars Hofhansl commented on HBASE-4404:
--------------------------------------
In your patch, wanna change the main loop in run() as well?
Also, I think stopper.stopped() should never be checked alone (without also checking running).
My patch is identical to yours except that it also changes these other places.
> ReplicationSource thread is not always shutdown when a peer is removed.
> -----------------------------------------------------------------------
>
> Key: HBASE-4404
> URL: https://issues.apache.org/jira/browse/HBASE-4404
> Project: HBase
> Issue Type: Bug
> Components: replication
> Affects Versions: 0.90.4, 0.92.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: 4404.txt
>
>
> When a replication peer is removed the ReplicationSource's thread is not shutdown if it is still trying to get a connection to the peer.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4404) ReplicationSource thread is not
always shutdown when a peer is removed.
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104729#comment-13104729 ]
Lars Hofhansl commented on HBASE-4404:
--------------------------------------
Ah yes, the patches are almost identical.
Are you going to check HBASE-4363 into 0.92.
I'll close this one as dup.
> ReplicationSource thread is not always shutdown when a peer is removed.
> -----------------------------------------------------------------------
>
> Key: HBASE-4404
> URL: https://issues.apache.org/jira/browse/HBASE-4404
> Project: HBase
> Issue Type: Bug
> Components: replication
> Affects Versions: 0.90.4, 0.92.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: 4404.txt
>
>
> When a replication peer is removed the ReplicationSource's thread is not shutdown if it is still trying to get a connection to the peer.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4404) ReplicationSource thread is not
always shutdown when a peer is removed.
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl reassigned HBASE-4404:
------------------------------------
Assignee: Lars Hofhansl
> ReplicationSource thread is not always shutdown when a peer is removed.
> -----------------------------------------------------------------------
>
> Key: HBASE-4404
> URL: https://issues.apache.org/jira/browse/HBASE-4404
> Project: HBase
> Issue Type: Bug
> Components: replication
> Affects Versions: 0.90.4, 0.92.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: 4404.txt
>
>
> When a replication peer is removed the ReplicationSource's thread is not shutdown if it is still trying to get a connection to the peer.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4404) ReplicationSource thread is not
always shutdown when a peer is removed.
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104720#comment-13104720 ]
Jean-Daniel Cryans commented on HBASE-4404:
-------------------------------------------
HBASE-4363?
> ReplicationSource thread is not always shutdown when a peer is removed.
> -----------------------------------------------------------------------
>
> Key: HBASE-4404
> URL: https://issues.apache.org/jira/browse/HBASE-4404
> Project: HBase
> Issue Type: Bug
> Components: replication
> Affects Versions: 0.90.4, 0.92.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: 4404.txt
>
>
> When a replication peer is removed the ReplicationSource's thread is not shutdown if it is still trying to get a connection to the peer.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4404) ReplicationSource thread is not
always shutdown when a peer is removed.
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl resolved HBASE-4404.
----------------------------------
Resolution: Duplicate
> ReplicationSource thread is not always shutdown when a peer is removed.
> -----------------------------------------------------------------------
>
> Key: HBASE-4404
> URL: https://issues.apache.org/jira/browse/HBASE-4404
> Project: HBase
> Issue Type: Bug
> Components: replication
> Affects Versions: 0.90.4, 0.92.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: 4404.txt
>
>
> When a replication peer is removed the ReplicationSource's thread is not shutdown if it is still trying to get a connection to the peer.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4404) ReplicationSource thread is not
always shutdown when a peer is removed.
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-4404:
---------------------------------
Attachment: 4404.txt
I propose this patch.
This just makes sure running=false is treated like stopper.isStopped().
> ReplicationSource thread is not always shutdown when a peer is removed.
> -----------------------------------------------------------------------
>
> Key: HBASE-4404
> URL: https://issues.apache.org/jira/browse/HBASE-4404
> Project: HBase
> Issue Type: Bug
> Components: replication
> Affects Versions: 0.90.4, 0.92.0
> Reporter: Lars Hofhansl
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: 4404.txt
>
>
> When a replication peer is removed the ReplicationSource's thread is not shutdown if it is still trying to get a connection to the peer.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4404) ReplicationSource thread is not
always shutdown when a peer is removed.
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104741#comment-13104741 ]
Jean-Daniel Cryans commented on HBASE-4404:
-------------------------------------------
It's a non-disruptive bug fix, will probably make it into 0.90 too. Mind giving it a review just to be sure? Thanks Lars.
> ReplicationSource thread is not always shutdown when a peer is removed.
> -----------------------------------------------------------------------
>
> Key: HBASE-4404
> URL: https://issues.apache.org/jira/browse/HBASE-4404
> Project: HBase
> Issue Type: Bug
> Components: replication
> Affects Versions: 0.90.4, 0.92.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: 4404.txt
>
>
> When a replication peer is removed the ReplicationSource's thread is not shutdown if it is still trying to get a connection to the peer.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira