[jira] [Commented] (YUNIKORN-2145) refactor: TrackedResource into its own file

["Kuan-Po Tseng (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YUNIKORN-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785349#comment-17785349 ] 

Kuan-Po Tseng commented on YUNIKORN-2145:
-----------------------------------------

Hi Wilfred ! I'm willing to do this although I'm not sure how to proceed, here are some thoughts about refactoring.
 # I guess you mean refactor out [https://github.com/apache/yunikorn-core/blob/ffb5bf5c568cd556c1b2372c95cde5a1d3b9f51e/pkg/common/resources/resources.go#L50-L99 |https://github.com/apache/yunikorn-core/blob/ffb5bf5c568cd556c1b2372c95cde5a1d3b9f51e/pkg/common/resources/resources.go#L50-L99]to tracked_resource.go since I didn't found TrackedResource type in resource.go
 # resource.go#UsedResource is only used in application.go#Application, maybe we can use the lock in application instead of using the lock in UsedResource.

 

 

> refactor: TrackedResource into its own file
> -------------------------------------------
>
>                 Key: YUNIKORN-2145
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2145
>             Project: Apache YuniKorn
>          Issue Type: Task
>          Components: core - scheduler
>            Reporter: Wilfred Spiegelenburg
>            Assignee: PoAn Yang
>            Priority: Major
>
> TrackedResource is a type on its own which should not be included in the generic Resource file. Move the type and releated functions into its own tracked_resource.go file. Move the related tests out too



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org