You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/02 16:41:51 UTC
[GitHub] [airflow] potiuk opened a new pull request, #26138: Replace spelling wordlst sorting with Python
potiuk opened a new pull request, #26138:
URL: https://github.com/apache/airflow/pull/26138
Part of #26020
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #26138: Replace spelling wordlist sorting with Python
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #26138:
URL: https://github.com/apache/airflow/pull/26138#discussion_r962085952
##########
docs/spelling_wordlist.txt:
##########
@@ -1594,24 +1577,41 @@ winrm
workgroup
workgroups
wsman
+WTF
wtf
wtforms
www
+XCom
+Xcom
xcom
+XComArg
xcomarg
+XComArgs
xcomresult
+XComs
+Xero
+Xiaodong
xml
xpath
xyz
yaml
+Yamllint
+Yandex
yandex
yandexcloud
yarnpkg
+Yieldr
yml
youtrack
youtube
zA
+Zego
+Zendesk
zendesk
Review Comment:
IIRC the spell checker is case insensitive so we should be able to get rid of these duplicates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a diff in pull request #26138: Replace spelling wordlist sorting with Python
Posted by GitBox <gi...@apache.org>.
mik-laj commented on code in PR #26138:
URL: https://github.com/apache/airflow/pull/26138#discussion_r962151175
##########
.pre-commit-config.yaml:
##########
@@ -591,10 +591,11 @@ repos:
require_serial: true
- id: update-spelling-wordlist-to-be-sorted
name: Sort alphabetically and uniquify spelling_wordlist.txt
- entry: ./scripts/ci/pre_commit/pre_commit_sort_spelling_wordlist.sh
- language: system
+ entry: ./scripts/ci/pre_commit/pre_commit_sort_spelling_wordlist.py
Review Comment:
@potiuk can you check if again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #26138: Replace spelling wordlist sorting with Python
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #26138:
URL: https://github.com/apache/airflow/pull/26138#discussion_r962152081
##########
.pre-commit-config.yaml:
##########
@@ -591,10 +591,11 @@ repos:
require_serial: true
- id: update-spelling-wordlist-to-be-sorted
name: Sort alphabetically and uniquify spelling_wordlist.txt
- entry: ./scripts/ci/pre_commit/pre_commit_sort_spelling_wordlist.sh
- language: system
+ entry: ./scripts/ci/pre_commit/pre_commit_sort_spelling_wordlist.py
Review Comment:
Now removed for sure :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a diff in pull request #26138: Replace spelling wordlist sorting with Python
Posted by GitBox <gi...@apache.org>.
mik-laj commented on code in PR #26138:
URL: https://github.com/apache/airflow/pull/26138#discussion_r961920024
##########
.pre-commit-config.yaml:
##########
@@ -591,10 +591,11 @@ repos:
require_serial: true
- id: update-spelling-wordlist-to-be-sorted
name: Sort alphabetically and uniquify spelling_wordlist.txt
- entry: ./scripts/ci/pre_commit/pre_commit_sort_spelling_wordlist.sh
- language: system
+ entry: ./scripts/ci/pre_commit/pre_commit_sort_spelling_wordlist.py
Review Comment:
Should we remove `./scripts/ci/pre_commit/pre_commit_sort_spelling_wordlist.sh` file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26138: Replace spelling wordlst sorting with Python
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26138:
URL: https://github.com/apache/airflow/pull/26138#issuecomment-1235711982
Not only replace the sorting with Python but also makes it case-insensitive (but stable) which makes it easier to find where to insert the word (I always struggled with casing there).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26138: Replace spelling wordlist sorting with Python
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26138:
URL: https://github.com/apache/airflow/pull/26138#issuecomment-1235920925
Removed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #26138: Replace spelling wordlist sorting with Python
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #26138:
URL: https://github.com/apache/airflow/pull/26138#discussion_r962132942
##########
docs/spelling_wordlist.txt:
##########
@@ -1594,24 +1577,41 @@ winrm
workgroup
workgroups
wsman
+WTF
wtf
wtforms
www
+XCom
+Xcom
xcom
+XComArg
xcomarg
+XComArgs
xcomresult
+XComs
+Xero
+Xiaodong
xml
xpath
xyz
yaml
+Yamllint
+Yandex
yandex
yandexcloud
yarnpkg
+Yieldr
yml
youtrack
youtube
zA
+Zego
+Zendesk
zendesk
Review Comment:
Actually this wordlist is used for both Sphinx spellchecker and the codespell and I think the Sphinx one isn't case sensitive (and It's good as we can detect some casing that is wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #26138: Replace spelling wordlist sorting with Python
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #26138:
URL: https://github.com/apache/airflow/pull/26138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #26138: Replace spelling wordlist sorting with Python
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #26138:
URL: https://github.com/apache/airflow/pull/26138#discussion_r962132942
##########
docs/spelling_wordlist.txt:
##########
@@ -1594,24 +1577,41 @@ winrm
workgroup
workgroups
wsman
+WTF
wtf
wtforms
www
+XCom
+Xcom
xcom
+XComArg
xcomarg
+XComArgs
xcomresult
+XComs
+Xero
+Xiaodong
xml
xpath
xyz
yaml
+Yamllint
+Yandex
yandex
yandexcloud
yarnpkg
+Yieldr
yml
youtrack
youtube
zA
+Zego
+Zendesk
zendesk
Review Comment:
Actually this wordlist is used for both Sphinx spellchecker and the codespell and I think the Sphinx isn't case sensitive (and It's good as we can detect some casing that is wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org