[jira] [Commented] (CASSANDRA-16956) Remove windows-specific classes

["Stefan Miklosovic (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486137#comment-17486137 ] 

Stefan Miklosovic commented on CASSANDRA-16956:
-----------------------------------------------

Based on the discussions held here as well as on the mailing list here (1), we will go with the patch for trunk only (being released in 4.1) and leaving patch release untouched. (4.0.x)

I propose this branch to be merged to trunk:

branch: https://github.com/instaclustr/cassandra/commits/CASSANDRA-16956-trunk-newest-2
CI build: https://app.circleci.com/pipelines/github/instaclustr/cassandra/679/workflows/63813973-1709-4766-bf6a-274e0526d36e

I am waiting for +1's here ([~brandon.williams], [~jmckenzie], [~bereng])

(1) https://lists.apache.org/thread/b32ngsfrc3jjw4xvvrrc34clrlcnd14b

> Remove windows-specific classes
> -------------------------------
>
>                 Key: CASSANDRA-16956
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16956
>             Project: Cassandra
>          Issue Type: Task
>          Components: Build
>            Reporter: Brandon Williams
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 4.0.x, 4.x
>
>         Attachments: signature.asc, signature.asc, signature.asc, signature.asc, signature.asc, signature.asc, signature.asc, signature.asc
>
>
> To continue the work CASSANDRA-16171 began, now that Windows support is no more there are some source files that can be removed.
> Just doing a naive grep on the source directory I see:
> {noformat}
> src/java/org/apache/cassandra/db/WindowsFailedSnapshotTracker.java
> src/java/org/apache/cassandra/utils/NativeLibraryWindows.java
> src/java/org/apache/cassandra/utils/WindowsTimer.java
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org