[jira] [Created] (TOMEE-1417) [TEST] Incorrect test function PropertiesTest assertTest

["Daniel Kasmeroglu (JIRA)" <ji...@apache.org>]

Daniel Kasmeroglu created TOMEE-1417:
----------------------------------------

             Summary: [TEST] Incorrect test function PropertiesTest assertTest
                 Key: TOMEE-1417
                 URL: https://issues.apache.org/jira/browse/TOMEE-1417
             Project: TomEE
          Issue Type: Improvement
    Affects Versions: 2.0.0
            Reporter: Daniel Kasmeroglu
            Priority: Trivial
             Fix For: 2.0.0


The helper function _PropertiesTest$assertProperties_ contains an invalid comparison for a different property:

{code:java}
if (expectedValue != expectedValue && (expectedValue == null || !expectedValue.equals(actual))) {
  ...
}
{code}

The comparison *expectedValue != expectedValue* obviously always returns false so the contained code will never be executed.

Furthermore the only use cases of this function returns at it's entry due to the fact that the supplied parameters are always equal.





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)