You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/16 05:22:46 UTC

[GitHub] [flink] KurtYoung opened a new pull request #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts

KurtYoung opened a new pull request #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts
URL: https://github.com/apache/flink/pull/11765
 
 
   Save the cli command history to a hidden file and make it available after sql cli restarts

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KurtYoung commented on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts

Posted by GitBox <gi...@apache.org>.
KurtYoung commented on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts
URL: https://github.com/apache/flink/pull/11765#issuecomment-615074990
 
 
   Good point, I will try to write some. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts
URL: https://github.com/apache/flink/pull/11765#issuecomment-614430999
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557",
       "triggerID" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160495175",
       "triggerID" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160495175",
       "triggerID" : "615003412",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557",
       "triggerID" : "615003412",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "f22365d16c850c88eb2a89cd5924c554159136a9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f22365d16c850c88eb2a89cd5924c554159136a9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160495175) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557) 
   * f22365d16c850c88eb2a89cd5924c554159136a9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts
URL: https://github.com/apache/flink/pull/11765#issuecomment-614430999
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557",
       "triggerID" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160495175",
       "triggerID" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160495175",
       "triggerID" : "615003412",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557",
       "triggerID" : "615003412",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "f22365d16c850c88eb2a89cd5924c554159136a9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7672",
       "triggerID" : "f22365d16c850c88eb2a89cd5924c554159136a9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f22365d16c850c88eb2a89cd5924c554159136a9",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160736929",
       "triggerID" : "f22365d16c850c88eb2a89cd5924c554159136a9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f22365d16c850c88eb2a89cd5924c554159136a9 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160736929) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7672) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] godfreyhe commented on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts
URL: https://github.com/apache/flink/pull/11765#issuecomment-615007657
 
 
   I think we can learn from https://github.com/oncewang/hive/blob/master/beeline/src/test/org/apache/hive/beeline/TestBeeLineHistory.java

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts
URL: https://github.com/apache/flink/pull/11765#issuecomment-614423109
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6 (Thu Apr 16 05:26:07 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts
URL: https://github.com/apache/flink/pull/11765#issuecomment-614430999
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557",
       "triggerID" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160495175",
       "triggerID" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160495175",
       "triggerID" : "615003412",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160495175) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts
URL: https://github.com/apache/flink/pull/11765#issuecomment-614430999
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557",
       "triggerID" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160495175",
       "triggerID" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160495175",
       "triggerID" : "615003412",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557",
       "triggerID" : "615003412",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160495175) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts
URL: https://github.com/apache/flink/pull/11765#issuecomment-614430999
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557",
       "triggerID" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160495175",
       "triggerID" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160495175",
       "triggerID" : "615003412",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557",
       "triggerID" : "615003412",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "f22365d16c850c88eb2a89cd5924c554159136a9",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7672",
       "triggerID" : "f22365d16c850c88eb2a89cd5924c554159136a9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f22365d16c850c88eb2a89cd5924c554159136a9",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160736929",
       "triggerID" : "f22365d16c850c88eb2a89cd5924c554159136a9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f22365d16c850c88eb2a89cd5924c554159136a9 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160736929) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7672) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] godfreyhe commented on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts
URL: https://github.com/apache/flink/pull/11765#issuecomment-614999923
 
 
   @KurtYoung Thanks for the contribution. can this feature be tested in UT ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] godfreyhe edited a comment on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts

Posted by GitBox <gi...@apache.org>.
godfreyhe edited a comment on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts
URL: https://github.com/apache/flink/pull/11765#issuecomment-615007657
 
 
   I think we can learn from https://github.com/oncewang/hive/blob/master/beeline/src/test/org/apache/hive/beeline/TestBeeLineHistory.java
   
   There are some tests based on `Terminal` in `CliClientTest`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KurtYoung commented on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts

Posted by GitBox <gi...@apache.org>.
KurtYoung commented on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts
URL: https://github.com/apache/flink/pull/11765#issuecomment-614773268
 
 
   @flinkbot run azure

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts
URL: https://github.com/apache/flink/pull/11765#issuecomment-614430999
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557",
       "triggerID" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160495175",
       "triggerID" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160495175) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts
URL: https://github.com/apache/flink/pull/11765#issuecomment-614430999
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557",
       "triggerID" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160495175",
       "triggerID" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160495175",
       "triggerID" : "615003412",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557",
       "triggerID" : "615003412",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160495175) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts
URL: https://github.com/apache/flink/pull/11765#issuecomment-614430999
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557",
       "triggerID" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160495175",
       "triggerID" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160495175) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KurtYoung commented on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts

Posted by GitBox <gi...@apache.org>.
KurtYoung commented on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts
URL: https://github.com/apache/flink/pull/11765#issuecomment-615003412
 
 
   @flinkbot run travis

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KurtYoung commented on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts

Posted by GitBox <gi...@apache.org>.
KurtYoung commented on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts
URL: https://github.com/apache/flink/pull/11765#issuecomment-615003107
 
 
   I'm not sure we have a good way to test the history of JLine reader, but I do test it in my local setup. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts
URL: https://github.com/apache/flink/pull/11765#issuecomment-614430999
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557",
       "triggerID" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160495175",
       "triggerID" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160495175) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts
URL: https://github.com/apache/flink/pull/11765#issuecomment-614430999
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557",
       "triggerID" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160495175",
       "triggerID" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160495175",
       "triggerID" : "615003412",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557",
       "triggerID" : "615003412",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "f22365d16c850c88eb2a89cd5924c554159136a9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7672",
       "triggerID" : "f22365d16c850c88eb2a89cd5924c554159136a9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f22365d16c850c88eb2a89cd5924c554159136a9",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160736929",
       "triggerID" : "f22365d16c850c88eb2a89cd5924c554159136a9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160495175) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7557) 
   * f22365d16c850c88eb2a89cd5924c554159136a9 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160736929) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7672) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KurtYoung closed pull request #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts

Posted by GitBox <gi...@apache.org>.
KurtYoung closed pull request #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts
URL: https://github.com/apache/flink/pull/11765
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11765: [FLINK-8864][sql-client] Add cli command history in sql client and make it available after restarts
URL: https://github.com/apache/flink/pull/11765#issuecomment-614430999
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 22eef4c43cd4fd0a6ddffb3cbef00a2fe522dac6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services