You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ferruzzi (via GitHub)" <gi...@apache.org> on 2024/05/06 19:24:59 UTC

[PR] Amazon Bedrock system test - Skip Provisioned Throughput workflow [airflow]

ferruzzi opened a new pull request, #39443:
URL: https://github.com/apache/airflow/pull/39443

   The Bedrock team recently implemented a restriction against internal teams creating no-commitment throughput in order to reserve that capacity for public users.  That change causes this test to fail with a ServiceQuotaExceededException when run in our internal team system test dashboard stack.  Skipping that block of the test will allow us to retain the sample code snippets and get the test passing again, albeit without actually testing that API call anymore.
   
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Amazon Bedrock system test - Skip Provisioned Throughput workflow [airflow]

Posted by "syedahsn (via GitHub)" <gi...@apache.org>.
syedahsn commented on code in PR #39443:
URL: https://github.com/apache/airflow/pull/39443#discussion_r1591504489


##########
tests/system/providers/amazon/aws/example_bedrock.py:
##########
@@ -56,6 +56,12 @@
 # the code snippets for docs, and we can manually run the full tests.
 SKIP_LONG_TASKS = environ.get("SKIP_LONG_SYSTEM_TEST_TASKS", default=True)
 
+# No-commitment Provisioned Throughput is currently restricted to external
+# customers only and will fail with a ServiceQuotaExceededException if run
+# on the AWS System Test stack.
+SKIP_RESTRICTED_TASKS = environ.get("SKIP_RESTRICTED_SYSTEM_TEST_TASKS", default=True)

Review Comment:
   Nit: Maybe its better to include the specific task with this flag (e.g. `SKIP_PROVISION_THROUGHPUT` etc.) I doubt that there will be more than one task that is restricted in a system test, in which case it makes sense to give the flag a more specific name.
   
   In the case that there are multiple restricted tasks, you'd still be better off with different flags because users might want to enable one task, but not others. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Amazon Bedrock system test - Skip Provisioned Throughput workflow [airflow]

Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on code in PR #39443:
URL: https://github.com/apache/airflow/pull/39443#discussion_r1591516155


##########
tests/system/providers/amazon/aws/example_bedrock.py:
##########
@@ -56,6 +56,12 @@
 # the code snippets for docs, and we can manually run the full tests.
 SKIP_LONG_TASKS = environ.get("SKIP_LONG_SYSTEM_TEST_TASKS", default=True)
 
+# No-commitment Provisioned Throughput is currently restricted to external
+# customers only and will fail with a ServiceQuotaExceededException if run
+# on the AWS System Test stack.
+SKIP_RESTRICTED_TASKS = environ.get("SKIP_RESTRICTED_SYSTEM_TEST_TASKS", default=True)

Review Comment:
   Yeah, I could do that.   My thinking with the name on the SKIP_LONG was that we might eventually have more than one and could set the skip or not flag as an environment variable and run the fulllllll tests on some sort of longer interval or trigger them manually, and I kind of just followed that naming convention here.    I think you are right, I don't see multiple tests having this kind of issue, so the name doesn't need to be so generic.  I'll rename it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Amazon Bedrock system test - Skip Provisioned Throughput workflow [airflow]

Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas merged PR #39443:
URL: https://github.com/apache/airflow/pull/39443


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org