[jira] Commented: (SHINDIG-776) Features Javascript has lots and lots of jslint errors

["Henning Schmiedehausen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662841#action_12662841 ] 

Henning Schmiedehausen commented on SHINDIG-776:
------------------------------------------------

Some of the functions have been reshuffled because javascript actually requires a function to be defined before used. But I actually tried to be careful not to change whitespaces. So I am not clear which whitespace changes you refer to. I can put that up for code review if that helps you pointing out the problems.

> Features Javascript has lots and lots of jslint errors
> ------------------------------------------------------
>
>                 Key: SHINDIG-776
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-776
>             Project: Shindig
>          Issue Type: Bug
>          Components: Features (Javascript)
>    Affects Versions: 1.0.x-incubating
>            Reporter: Henning Schmiedehausen
>             Fix For: 1.0.0-rc1
>
>         Attachments: SHINDIG-776.patch
>
>
> I ran jslint (using just browser, eqeqeq, undef, sub) on the features tree (as I did routinely with our internal javascript for 0.7) and I was amazed to see literally hundreds of errors. 
> This patch tries to fix the biggest problems (usage of undefined fields, != vs. !==, == vs. ===, lots of missing semicolons). It probably needs some discussion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.