You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/24 09:32:05 UTC
[GitHub] [flink-kubernetes-operator] tisonkun opened a new pull request, #241: FLINK-27746: Remove COPY .git in dockerfile
tisonkun opened a new pull request, #241:
URL: https://github.com/apache/flink-kubernetes-operator/pull/241
As build process doesn't depend on those files.
Signed-off-by: tison <wa...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] tisonkun closed pull request #241: [FLINK-27746] Replace git-commit-id-maven-plugin with script
Posted by GitBox <gi...@apache.org>.
tisonkun closed pull request #241: [FLINK-27746] Replace git-commit-id-maven-plugin with script
URL: https://github.com/apache/flink-kubernetes-operator/pull/241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] tisonkun commented on pull request #241: FLINK-27746: Remove COPY .git in dockerfile
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #241:
URL: https://github.com/apache/flink-kubernetes-operator/pull/241#issuecomment-1135716862
@morhidi thanks for pointing this out. Then I think @SteNicholas can handle this whole story properly. Closed as lack of background.
Although, an insight is that we may use another approach to generate git.property since the released tarball normally excludes `.git` artifacts (or we'd like to include them?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #241: FLINK-27746: Remove COPY .git in dockerfile
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #241:
URL: https://github.com/apache/flink-kubernetes-operator/pull/241#issuecomment-1135738791
cc @wangyang0918 WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #241: FLINK-27746: Remove COPY .git in dockerfile
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #241:
URL: https://github.com/apache/flink-kubernetes-operator/pull/241#issuecomment-1135688976
cc @SteNicholas I guess this was part of FLINK-27124] Flink Kubernetes operator prints starting logs with corrent version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] tisonkun closed pull request #241: FLINK-27746: Remove COPY .git in dockerfile
Posted by GitBox <gi...@apache.org>.
tisonkun closed pull request #241: FLINK-27746: Remove COPY .git in dockerfile
URL: https://github.com/apache/flink-kubernetes-operator/pull/241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] tisonkun commented on pull request #241: [FLINK-27746] Replace git-commit-id-maven-plugin with script
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #241:
URL: https://github.com/apache/flink-kubernetes-operator/pull/241#issuecomment-1136032335
It happens that I get some spare time to work on this issue. So now I replace git-commit-id-maven-plugin with script and get rid of force dependency on `.git`.
Note that Dockerfile doesn't support conditional COPY so we should do such conditional generate/copy works outside the scope of Dockerfile.
cc @wangyang0918 @SteNicholas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #241: FLINK-27746: Remove COPY .git in dockerfile
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on PR #241:
URL: https://github.com/apache/flink-kubernetes-operator/pull/241#issuecomment-1135821076
I lean to skip copying the `.git` directory if not exist. Then the version in log will be `UNKNOWN` if building the image with source release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] tisonkun commented on pull request #241: [FLINK-27746] Replace git-commit-id-maven-plugin with script
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #241:
URL: https://github.com/apache/flink-kubernetes-operator/pull/241#issuecomment-1136067938
Closed in favor of #243. This patch never builds the image with git props.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org