You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/10/27 07:45:45 UTC
[GitHub] [dolphinscheduler] yangqiyu0306 opened a new issue #6613: [Bug] [Master] A bug on task retry mechanism
yangqiyu0306 opened a new issue #6613:
URL: https://github.com/apache/dolphinscheduler/issues/6613
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
There are process nodes at the same level in the process, a failed error retry "node1_fail_retry" node (the actual task scenario may fail for the first time, and the task runs successfully after retry), and a failed "node2_fail" node;
The current phenomenon is that after the "node2_fail" node fails, the process is in the failure state, and the "node1_fail_retry" node will not retry the task (the retry state may be successful) and the subsequent tasks will not run;
Because the "node2_fail" node fails and the "errorTaskList" in the "MasterExecThread" is not empty, in the "processFailed()" method, "hasFailedTask()" returns true. When the FailureStrategy is CONTINUE, "activetasknode = 0", "processFailed()" returns false, causing the process instance state to change to failed.
### What you expected to happen
I think it is wrong not to retry the process node at the same level if it fails, because the actual task scenario may fail for the first time, run successfully after retrying, and then continue to run the downstream node.
### How to reproduce
1. Create a new process
2. Create a process node relationship as shown in the figure. The node "node1_fail_retry" is set error retry. The node "node2_fail" fails directly. Nodes "node3", "node4" and "node5 "can be created arbitrarily
3. Online process and runprocess
<img width="878" alt="22" src="https://user-images.githubusercontent.com/39785282/139022278-1eae4ae2-d935-429a-b861-3232733f73f1.png">
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #6613: [Bug] [Master] A bug on task retry mechanism
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #6613:
URL: https://github.com/apache/dolphinscheduler/issues/6613#issuecomment-952629929
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/zh-cn/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] lenboo closed issue #6613: [Bug] [Master] A bug on task retry mechanism
Posted by GitBox <gi...@apache.org>.
lenboo closed issue #6613:
URL: https://github.com/apache/dolphinscheduler/issues/6613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] yangqiyu0306 commented on issue #6613: [Bug] [Master] A bug on task retry mechanism
Posted by GitBox <gi...@apache.org>.
yangqiyu0306 commented on issue #6613:
URL: https://github.com/apache/dolphinscheduler/issues/6613#issuecomment-953443937
> > 哪个版本？
>
> 我认为我们必须为我们的错误模板添加版本选择。
> which version?
I use 1.2.1， but this logic is the same as other version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] yangqiyu0306 commented on issue #6613: [Bug] [Master] A bug on task retry mechanism
Posted by GitBox <gi...@apache.org>.
yangqiyu0306 commented on issue #6613:
URL: https://github.com/apache/dolphinscheduler/issues/6613#issuecomment-952724583
I use 1.2.1， but this logic is the same as other version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] lenboo commented on issue #6613: [Bug] [Master] A bug on task retry mechanism
Posted by GitBox <gi...@apache.org>.
lenboo commented on issue #6613:
URL: https://github.com/apache/dolphinscheduler/issues/6613#issuecomment-952716542
which version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #6613: [Bug] [Master] A bug on task retry mechanism
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #6613:
URL: https://github.com/apache/dolphinscheduler/issues/6613#issuecomment-952944539
> which version?
I think we have to add version selection for our bug template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org