[jira] [Commented] (LUCENE-10155) Refactor TestMultiMMap into a BaseChunkedDirectoryTestCase

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-10155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426611#comment-17426611 ] 

ASF subversion and git services commented on LUCENE-10155:
----------------------------------------------------------

Commit 6c6a3bd5bd58579ecf31acee1178141c9138eac6 in lucene's branch refs/heads/main from Robert Muir
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=6c6a3bd ]

LUCENE-10155: Refactor TestMultiMMap into a BaseChunkedDirectoryTestCase (#360)

BaseChunkedDirectoryTestCase is an extension of BaseDirectoryTestCase
where the concrete test class instantiates with a specified chunk size.
It then tries to test boundary conditions around all the chunking.


> Refactor TestMultiMMap into a BaseChunkedDirectoryTestCase
> ----------------------------------------------------------
>
>                 Key: LUCENE-10155
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10155
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>            Priority: Major
>             Fix For: main (9.0)
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> TestMultiMMap requests tiny chunk sizes, then tests around all the boundaries.
> But ByteBuffersDirectory is basically doing the same thing: let's factor this logic into a base test class that both can use?
> The new base test class just requires the concrete test to be able to instantiate directory with a specified chunk size, e.g.:
> {code}
>   /** Creates a new directory with the specified max chunk size */
>   protected abstract Directory getDirectory(Path path, int maxChunkSize) throws IOException;
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org