You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "dan-s1 (via GitHub)" <gi...@apache.org> on 2026/06/25 20:28:53 UTC
[PR] NIFI-16049 Corrected if else logic in FlowFileUnpackagerV1 [nifi]
dan-s1 opened a new pull request, #11370:
URL: https://github.com/apache/nifi/pull/11370
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-16049](https://issues.apache.org/jira/browse/NIFI-16049)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
- Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status
### Pull Request Formatting
- Pull Request based on current revision of the `main` branch
- Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `./mvnw clean install -P contrib-check`
- [ ] JDK 21
- [ ] JDK 25
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16049 Corrected if else logic in FlowFileUnpackagerV1 [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory merged PR #11370:
URL: https://github.com/apache/nifi/pull/11370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16049 Corrected if else logic in FlowFileUnpackagerV1 [nifi]
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 commented on code in PR #11370:
URL: https://github.com/apache/nifi/pull/11370#discussion_r3480269513
##########
nifi-commons/nifi-flowfile-packager/src/main/java/org/apache/nifi/util/FlowFileUnpackagerV1.java:
##########
@@ -78,18 +78,17 @@ protected Map<String, String> getAttributes(final TarArchiveInputStream stream)
for (final Entry<Object, Object> entry : props.entrySet()) {
final Object keyObject = entry.getKey();
final Object valueObject = entry.getValue();
- if (!(keyObject instanceof String)) {
+ if (!(keyObject instanceof final String key)) {
throw new IOException("Flow file attributes object contains key of type "
+ keyObject.getClass().getCanonicalName()
+ " but expected java.lang.String");
- } else if (!(keyObject instanceof String)) {
+ }
+ if (!(valueObject instanceof final String value)) {
throw new IOException("Flow file attributes object contains value of type "
+ keyObject.getClass().getCanonicalName()
Review Comment:
In the value type error, should this report valueObject.getClass().getCanonicalName() instead of keyObject, so the message shows the actual type of the bad value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16049 Corrected if else logic in FlowFileUnpackagerV1 [nifi]
Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on PR #11370:
URL: https://github.com/apache/nifi/pull/11370#issuecomment-4846399556
@exceptionfactory When writing a unit test, I came across an issue that I cannot write in an XML file using the `java.util.Properties` `storeToXML` attributes which are not a string (i.e. both key and value need to be strings). Furthermore in the `FlowFilePackagerV1` code in method `packageFlowFile` it seems it only takes a map of attributes whose keys and values are only strings. Hence I question, why there are these checks in `FlowFileUnpackagerV1` in the first place? Perhaps we should remove these checks entirely. I do have a unit test to test unpackaging in a normal scenario which I can contribute if you wish. Please advise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16049 Corrected if else logic in FlowFileUnpackagerV1 [nifi]
Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on PR #11370:
URL: https://github.com/apache/nifi/pull/11370#issuecomment-4845535595
@exceptionfactory Probably a unit test could be written but not easily. Currently the only unit test in that package is for `FlowFilePackagerV3` and `FlowFileUnpackagerV3` but none for `FlowFileUnpackagerV1` and `FlowFileUnpackagerV2`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org