You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "HScarb (via GitHub)" <gi...@apache.org> on 2023/05/24 08:42:52 UTC
[GitHub] [rocketmq] HScarb opened a new pull request, #6806: [ISSUE ##6805] Add peek API support
HScarb opened a new pull request, #6806:
URL: https://github.com/apache/rocketmq/pull/6806
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #6805
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
Add peek API support in `MQClientAPIImpl` and `MQClientAPIExt`, and use `processPopResponse` method to process peek response.
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #6806: [ISSUE ##6805] Add peek API support
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6806:
URL: https://github.com/apache/rocketmq/pull/6806#issuecomment-1560735214
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/6806?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#6806](https://app.codecov.io/gh/apache/rocketmq/pull/6806?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8282505) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/985319ba2abd633540133220ce2d95bb7dde0ad8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (985319b) will **decrease** coverage by `0.03%`.
> The diff coverage is `16.27%`.
```diff
@@ Coverage Diff @@
## develop #6806 +/- ##
=============================================
- Coverage 42.83% 42.80% -0.03%
Complexity 8989 8989
=============================================
Files 1105 1105
Lines 78471 78514 +43
Branches 10227 10232 +5
=============================================
- Hits 33612 33609 -3
- Misses 40645 40684 +39
- Partials 4214 4221 +7
```
| [Impacted Files](https://app.codecov.io/gh/apache/rocketmq/pull/6806?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../rocketmq/client/impl/mqclient/MQClientAPIExt.java](https://app.codecov.io/gh/apache/rocketmq/pull/6806?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9tcWNsaWVudC9NUUNsaWVudEFQSUV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../apache/rocketmq/test/client/rmq/RMQPopClient.java](https://app.codecov.io/gh/apache/rocketmq/pull/6806?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9jbGllbnQvcm1xL1JNUVBvcENsaWVudC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...g/apache/rocketmq/client/impl/MQClientAPIImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/6806?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUNsaWVudEFQSUltcGwuamF2YQ==) | `23.73% <38.88%> (+0.35%)` | :arrow_up: |
... and [20 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/6806/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org