You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/28 08:45:19 UTC

[GitHub] [spark] zhengruifeng opened a new pull request, #38423: [SPARK-40949][CONNECT][PYTHON] Implement `DataFrame.sortWithinPartitions`

zhengruifeng opened a new pull request, #38423:
URL: https://github.com/apache/spark/pull/38423

   ### What changes were proposed in this pull request?
   Implement `DataFrame.sortWithinPartitions`
   
   
   ### Why are the changes needed?
   for api coverage
   
   
   ### Does this PR introduce _any_ user-facing change?
   yes, new method
   
   
   ### How was this patch tested?
   added UT


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng closed pull request #38423: [SPARK-40949][CONNECT][PYTHON] Implement `DataFrame.sortWithinPartitions`

Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #38423: [SPARK-40949][CONNECT][PYTHON] Implement `DataFrame.sortWithinPartitions`
URL: https://github.com/apache/spark/pull/38423


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on pull request #38423: [SPARK-40949][CONNECT][PYTHON] Implement `DataFrame.sortWithinPartitions`

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38423:
URL: https://github.com/apache/spark/pull/38423#issuecomment-1298023324

   the 3 force pushes only resolved conflicts in generated files, let me merge it now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] amaliujia commented on pull request #38423: [SPARK-40949][CONNECT][PYTHON] Implement `DataFrame.sortWithinPartitions`

Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38423:
URL: https://github.com/apache/spark/pull/38423#issuecomment-1298056172

   Late LGTM thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on pull request #38423: [SPARK-40949][CONNECT][PYTHON] Implement `DataFrame.sortWithinPartitions`

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38423:
URL: https://github.com/apache/spark/pull/38423#issuecomment-1298024181

   merged into master, thanks @HyukjinKwon 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on a diff in pull request #38423: [SPARK-40949][CONNECT][PYTHON] Implement `DataFrame.sortWithinPartitions`

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #38423:
URL: https://github.com/apache/spark/pull/38423#discussion_r1007815060


##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -168,6 +168,7 @@ message Aggregate {
 message Sort {
   Relation input = 1;
   repeated SortField sort_fields = 2;
+  bool is_global = 3;

Review Comment:
   unfortunately, `global` is a Python keyword, so name it as `is_global`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org