[GitHub] flink pull request #6055: [FLINK-8511][table] Remove legacy code for the Tab...

[kisimple <gi...@git.apache.org>]

GitHub user kisimple opened a pull request:

    https://github.com/apache/flink/pull/6055

    [FLINK-8511][table] Remove legacy code for the TableType annotation

    ## What is the purpose of the change
    
    TableSource factories had already been used to unify the definition of table sources, the old `TableType` code paths can be removed safely.
    
    ## Brief change log
    
      - Delete TableType.java/TableSourceConverter.java/CsvTableSourceConverter.java/tableSourceConverter.properties
      -  Delete `NoMatchedTableSourceConverterException`/`AmbiguousTableSourceConverterException`
      - Delete ExternalTableSourceUtilTest.java cause it only test the `TableType` code paths
      - Drop the org.reflections and commons-configuration dependencies
      - Remove legacy code in ExternalCatalogTable.scala and ExternalTableSourceUtil.scala
      - Update CommonTestData.scala/InMemoryExternalCatalogTest.scala to adapt with `ExternalCatalogTable`
      - Update ExternalCatalogSchemaTest.scala to adapt with `ExternalTableSourceUtil`
    
    ## Verifying this change
    
    This change is already covered by existing tests.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kisimple/flink FLINK-8511

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6055.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6055
    
----
commit 719930a590d6fec26117253d2f0a19b4a1a1a54d
Author: blueszheng <ki...@...>
Date:   2018-05-22T12:52:35Z

    [FLINK-8511][table] Remove legacy code for the TableType annotation

----


---

[GitHub] flink issue #6055: [FLINK-8511][table] Remove legacy code for the TableType ...

[twalthr <gi...@git.apache.org>]

Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/6055
  
    Thank you @kisimple. The PR looks good.
    
    We can also remove the `jcl-over-slf4j` dependency and update the `dependencyManagement` section. But I will do this and merge this after testing.


---

[GitHub] flink pull request #6055: [FLINK-8511][table] Remove legacy code for the Tab...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/6055


---