You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/10/17 12:58:54 UTC

[GitHub] [camel] gnodet opened a new pull request, #8562: Jdk17 support

gnodet opened a new pull request, #8562:
URL: https://github.com/apache/camel/pull/8562

   <!-- Uncomment and fill this section if your PR is not trivial
   - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
   - [ ] Each commit in the pull request should have a meaningful subject line and body.
   - [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
   Below are the contribution guidelines:
   https://github.com/apache/camel/blob/main/CONTRIBUTING.md
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] gnodet closed pull request #8562: Jdk17 support

Posted by GitBox <gi...@apache.org>.
gnodet closed pull request #8562: Jdk17 support
URL: https://github.com/apache/camel/pull/8562


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] davsclaus commented on pull request #8562: Jdk17 support

Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8562:
URL: https://github.com/apache/camel/pull/8562#issuecomment-1280935631

   3.18.x is later this week, so would be good to do that first.
   3.20.0 is Nov/Dec depending on how active we are on this release


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] github-actions[bot] commented on pull request #8562: Jdk17 support

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8562:
URL: https://github.com/apache/camel/pull/8562#issuecomment-1283536689

   :leftwards_arrow_with_hook: There are either **too many** changes to be tested in this PR or the code **needs be rebased**: (226 components likely to be affected)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] oscerd commented on pull request #8562: Jdk17 support

Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #8562:
URL: https://github.com/apache/camel/pull/8562#issuecomment-1283540907

   I would target them for Camel 4.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] davsclaus commented on pull request #8562: Jdk17 support

Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8562:
URL: https://github.com/apache/camel/pull/8562#issuecomment-1280925273

   Ah we need to upgrade the maven archetypes to JDK11 as JDK8 is dropped since 3.14.x. 
   That would be good to get into the 3.20 and 3.18.x releases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] gnodet commented on pull request #8562: Jdk17 support

Posted by GitBox <gi...@apache.org>.
gnodet commented on PR #8562:
URL: https://github.com/apache/camel/pull/8562#issuecomment-1283481109

   > 3.18.x is later this week, so would be good to do that first.
   > 3.20.0 is Nov/Dec depending on how active we are on this release
   
   I've pushed the commit to update the archetypes on 3.18.x and `main`.
   
   I'm going to have a look at supporting java `record`s , however, those have been introduced in JDK 14. Is the goal to raise the requirement to JDK 17 (as done in Spring 6) , or do we want to support `record` without raising the minimum requirements ? @davsclaus @oscerd 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] gnodet commented on pull request #8562: Jdk17 support

Posted by GitBox <gi...@apache.org>.
gnodet commented on PR #8562:
URL: https://github.com/apache/camel/pull/8562#issuecomment-1280931701

   > Ah we need to upgrade the maven archetypes to JDK11 as JDK8 is dropped since 3.14.x.
   > That would be good to get into the 3.20 and 3.18.x releases.
   
   Yeah, that makes sense to backport the changes in these branches first.  Any ETA for 3.20 / 3.18.x to make sure I don't miss anything ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] github-actions[bot] commented on pull request #8562: Jdk17 support

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8562:
URL: https://github.com/apache/camel/pull/8562#issuecomment-1280926095

   :no_entry_sign: There are (likely) no components to be tested in this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] davsclaus commented on pull request #8562: Jdk17 support

Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8562:
URL: https://github.com/apache/camel/pull/8562#issuecomment-1283510302

   The goal is for camel 4 which is JDK17 as minimum


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org