You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2018/05/18 20:05:32 UTC
[GitHub] michael-o commented on a change in pull request #74: [SCM-885]
third implementation
michael-o commented on a change in pull request #74: [SCM-885] third implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189379912
##########
File path: maven-scm-api/src/main/java/org/apache/maven/scm/command/changelog/AbstractChangeLogCommand.java
##########
@@ -76,13 +84,21 @@ public ScmResult executeCommand( ScmProviderRepository repository, ScmFileSet fi
ScmBranch branch = (ScmBranch) parameters.getScmVersion( CommandParameter.BRANCH, null );
+ ScmVersion version = parameters.getScmVersion( CommandParameter.SCM_VERSION, null );
+
ScmVersion startVersion = parameters.getScmVersion( CommandParameter.START_SCM_VERSION, null );
ScmVersion endVersion = parameters.getScmVersion( CommandParameter.END_SCM_VERSION, null );
String datePattern = parameters.getString( CommandParameter.CHANGELOG_DATE_PATTERN, null );
- if ( startVersion != null || endVersion != null )
+ boolean fromVersionToStartOfRepository = startVersion == null && endVersion == null && version != null;
Review comment:
The variable name is a bit confusing because we have `startVersion` and the name contains `start` too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services