You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@karaf.apache.org by Łukasz Dywicki <lu...@code-house.org> on 2013/04/03 11:26:59 UTC
KARAF-1305 and 2.3.x branch
Hey,
I just saw an issue related to SMX (SM-2185), and KARAF-1305. I didn't drive deeper into it, however I checked the 2.3.x jetty.xml and it looks that we still point to old principal class name:
https://github.com/apache/karaf/blob/karaf-2.3.x/assemblies/apache-karaf/src/main/resources/extra/jetty.xml#L80
Shouldn't it be a org.apache.karaf.jaas.boot.principal.RolePrincipal instead of org.apache.karaf.jaas.modules.RolePrincipal? For trunk it's fine.
Cheers,
Lukasz
Re: improvements to karaf plugin
Posted by Andrei Pozolotin <an...@gmail.com>.
great. please let me know when you feel your changes are ready for review.
-------- Original Message --------
Subject: Re: improvements to karaf plugin
From: Jean-Baptiste Onofré <jb...@nanthrax.net>
To: Andrei Pozolotin <an...@gmail.com>
Cc: dev@karaf.apache.org
Date: Thu 04 Apr 2013 02:26:08 PM CDT
> Hi Andrei,
>
> thanks for the update. I gonna take a look.
>
> About Maven Plugin, I plan to add karaf:run, karaf:client,
> karaf:deploy goals tomorrow.
>
> Your pointer is interesting, and again, I will take a look for sure.
>
> I keep you posted.
>
> Regards
> JB
>
> On 04/04/2013 07:41 PM, Andrei Pozolotin wrote:
>> Jean-Baptiste
>>
>> FYI:
>>
>> I asked maven people for some changes to maven which would
>> benefit karaf
>> http://www.mail-archive.com/dev@maven.apache.org/msg96360.html
>>
>> which they are not able to accept at the moment.
>>
>> nevertheless what Tamás is suggesting here
>> http://www.mail-archive.com/dev@maven.apache.org/msg96388.html
>>
>> in his example about nexus plugin, I think should be incorporated
>> into karaf plugin now,
>> at least for the @goal install-kars
>>
>> https://github.com/apache/karaf/tree/trunk/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/features
>>
>> https://github.com/apache/karaf/blob/trunk/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/features/InstallKarsMojo.java#L215
>>
>> Thank you,
>>
>> Andrei
>>
>
Re: improvements to karaf plugin
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Andrei,
thanks for the update. I gonna take a look.
About Maven Plugin, I plan to add karaf:run, karaf:client, karaf:deploy
goals tomorrow.
Your pointer is interesting, and again, I will take a look for sure.
I keep you posted.
Regards
JB
On 04/04/2013 07:41 PM, Andrei Pozolotin wrote:
> Jean-Baptiste
>
> FYI:
>
> I asked maven people for some changes to maven which would benefit karaf
> http://www.mail-archive.com/dev@maven.apache.org/msg96360.html
>
> which they are not able to accept at the moment.
>
> nevertheless what Tamás is suggesting here
> http://www.mail-archive.com/dev@maven.apache.org/msg96388.html
>
> in his example about nexus plugin, I think should be incorporated
> into karaf plugin now,
> at least for the @goal install-kars
> https://github.com/apache/karaf/tree/trunk/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/features
> https://github.com/apache/karaf/blob/trunk/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/features/InstallKarsMojo.java#L215
>
> Thank you,
>
> Andrei
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
improvements to karaf plugin
Posted by Andrei Pozolotin <an...@gmail.com>.
Jean-Baptiste
FYI:
I asked maven people for some changes to maven which would benefit karaf
http://www.mail-archive.com/dev@maven.apache.org/msg96360.html
which they are not able to accept at the moment.
nevertheless what Tamás is suggesting here
http://www.mail-archive.com/dev@maven.apache.org/msg96388.html
in his example about nexus plugin, I think should be incorporated
into karaf plugin now,
at least for the @goal install-kars
https://github.com/apache/karaf/tree/trunk/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/features
https://github.com/apache/karaf/blob/trunk/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/features/InstallKarsMojo.java#L215
Thank you,
Andrei
Re: KARAF-1305 and 2.3.x branch
Posted by Freeman Fang <fr...@gmail.com>.
No, this issue is still there, create KARAF-2259[1] to track it
[1]https://issues.apache.org/jira/browse/KARAF-2259
－－－－－－－－－－－－－
Freeman(Yue) Fang
Red Hat, Inc.
FuseSource is now part of Red Hat
Web: http://fusesource.com | http://www.redhat.com/
Twitter: freemanfang
Blog: http://freemanfang.blogspot.com
http://blog.sina.com.cn/u/1473905042
weibo: @Freeman小屋
On 2013-4-3, at 下午5:33, Jean-Baptiste Onofré wrote:
> Hi Lukasz,
>
> Yeah, the class name doesn't look the right one. But AFAIR, we already fix that (I remember something similar in WebConsole). I gonna take a look.
>
> Regards
> JB
>
> On 04/03/2013 11:26 AM, Łukasz Dywicki wrote:
>> Hey,
>> I just saw an issue related to SMX (SM-2185), and KARAF-1305. I didn't drive deeper into it, however I checked the 2.3.x jetty.xml and it looks that we still point to old principal class name:
>> https://github.com/apache/karaf/blob/karaf-2.3.x/assemblies/apache-karaf/src/main/resources/extra/jetty.xml#L80
>>
>> Shouldn't it be a org.apache.karaf.jaas.boot.principal.RolePrincipal instead of org.apache.karaf.jaas.modules.RolePrincipal? For trunk it's fine.
>>
>> Cheers,
>> Lukasz
>>
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
Re: KARAF-1305 and 2.3.x branch
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Lukasz,
Yeah, the class name doesn't look the right one. But AFAIR, we already
fix that (I remember something similar in WebConsole). I gonna take a look.
Regards
JB
On 04/03/2013 11:26 AM, Łukasz Dywicki wrote:
> Hey,
> I just saw an issue related to SMX (SM-2185), and KARAF-1305. I didn't drive deeper into it, however I checked the 2.3.x jetty.xml and it looks that we still point to old principal class name:
> https://github.com/apache/karaf/blob/karaf-2.3.x/assemblies/apache-karaf/src/main/resources/extra/jetty.xml#L80
>
> Shouldn't it be a org.apache.karaf.jaas.boot.principal.RolePrincipal instead of org.apache.karaf.jaas.modules.RolePrincipal? For trunk it's fine.
>
> Cheers,
> Lukasz
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com