You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/08 02:50:13 UTC

[GitHub] [shardingsphere] ZeldaBreath opened a new pull request, #19954: Modify the scope of the h2 dependency of the shardingsphere-example m…

ZeldaBreath opened a new pull request, #19954:
URL: https://github.com/apache/shardingsphere/pull/19954

   Fixes #19398.
   
   Changes proposed in this pull request:
   - Modify the scope of the h2 dependency of the shardingsphere-example module.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] ZeldaBreath closed pull request #19954: Modify the scope of the h2 dependency of the shardingsphere-example m…

Posted by GitBox <gi...@apache.org>.
ZeldaBreath closed pull request #19954: Modify the scope of the h2 dependency of the shardingsphere-example m…
URL: https://github.com/apache/shardingsphere/pull/19954


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #19954: Modify the scope of the h2 dependency of the shardingsphere-example m…

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19954:
URL: https://github.com/apache/shardingsphere/pull/19954#issuecomment-1207661353

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19954?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#19954](https://codecov.io/gh/apache/shardingsphere/pull/19954?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c53de4f) into [master](https://codecov.io/gh/apache/shardingsphere/commit/83473dcd4e53b52ff18368da47e5b71b423df81d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (83473dc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #19954   +/-   ##
   =========================================
     Coverage     60.25%   60.25%           
     Complexity     2412     2412           
   =========================================
     Files          3859     3859           
     Lines         54715    54715           
     Branches       7660     7660           
   =========================================
     Hits          32966    32966           
     Misses        18915    18915           
     Partials       2834     2834           
   ```
   
   
   
   :mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] ZeldaBreath commented on pull request #19954: Modify the scope of the h2 dependency of the shardingsphere-example m…

Posted by GitBox <gi...@apache.org>.
ZeldaBreath commented on PR #19954:
URL: https://github.com/apache/shardingsphere/pull/19954#issuecomment-1207597238

   If the scope of h2 dependency is test, org.h2.Driver cannot be registered with the SQL driver.
   ![image](https://user-images.githubusercontent.com/36617764/183329648-1531a87c-093b-42fd-af49-08306c21ce99.png)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org